jQuery 1.4.3 with data-confirm uses old dispatch mechanism, ignores data-confirm

[rails]

jQuery 1.4.3 with data-confirm uses old dispatch mechanism, ignores data-confirm

[neerajsingh0101]

Can you elaborate on the issue you are running into?

[onewland]

The 'if' statement on line 72 determines which code jQuery uses to attach itself to the data-confirm attributes to display the confirm() based dialog. It does not include a version check for jQuery 1.4.3, which needs to use the new style of attaching to the link. Because it doesn't check for 1.4.3 specifically, it drops into the old style of handling data-confirm which doesn't work for jQuery 1.4.3. Since it doesn't attach, the confirm doesn't get displayed and the confirmation dialog never pops up, and the click always goes through.

[neerajsingh0101]

The job of if condition is to check where to attach the confirmation. In jquery 1.4.3 I am attaching it at body and in other versions I am attaching it at document level.

Can you create an application and put it on github so that I could see the problem?

Also what browse you are using and what os you are using?

Thanks

[neerajsingh0101]

master has changed and it does not have if condition anymore.

If you want something to be pushed then please create a new pull request.

Thank you.

[onewland]

Yeah, sorry about my lack of attention; been quite busy lately.

If the issue still exists, I'll be more useful in my next submission.

[neerajsingh0101]

No need to be sorry.

Thanks for the pull request.