Giter Site home page Giter Site logo

Comments (3)

swistak35 avatar swistak35 commented on September 25, 2024 2

Well, if we want to provide backwards compatibility, as far as I understand:

  1. we should still have a dependency on rails_event_store_active_record
  2. we should remove deprecation warnings
  3. with 3.0 release, we change the dependency to ruby_event_store-active_record. It would be nice (but not mandatory) to also release 3.0 for both ruby_event_store-active_record and rails_event_store_active_record (and 3.0 being the last version of this one). Then people not using rails_event_store could make gradual change (since they have to explicitly specify rails_event_store_active_record if they use it)

I don't see other reason since we can't say "either that gem or this gem" in gemspec, or "if we have ruby_event_store-active_record, then we rails_event_store_active_record is no longer dependency".

I don't see value in deprecation warnings in 2.x, even if it would be last version of 2.x. Unless people can actually solve the deprecation (by using newer version), but they can't (they can only do that when being on 3.0, without rails_event_store).

from rails_event_store.

pawelpacana avatar pawelpacana commented on September 25, 2024

#1147

from rails_event_store.

pawelpacana avatar pawelpacana commented on September 25, 2024

Correct me if I'm wrong. As of now:

  • rails_event_store-2.6.0 depends on rails_event_store-2.6.0
  • rails_event_store-master depends on ruby_event_store-active_record-master

We did it because we control this dependency and replaced internally all invocations of RailsEventStoreActiveRecord with RubyEventStore::ActiveRecord.

We're also providing rails_event_store_active_record gem that:

  • has dependency to ruby_event_store-active_record
  • aliases RubyEventStore::ActiveRecord as RailsEventStoreActiveRecord
  • warns about rename in post-install message and when requiring rails_event_store_active_record

The only reason this aliased gem exists is for someone directly depending on it (which we don't control).

There's also the case of documentation pointing to RailsEventStoreActiveRecord, which we don't want to change in 2.x. Also someone might have customized RailsEventStoreActiveRecord so this const being stil present is fair expectation.

Should we then keep rails_event_store to depend on rails_event_store_active_record, being a wrapper on ruby_event_store-active_record? Do we hide deprecation warnings? Do we need to mention this deprecation in the docs?

@swistak35 @lukaszreszke

from rails_event_store.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.