Comments (3)
Well, if we want to provide backwards compatibility, as far as I understand:
- we should still have a dependency on
rails_event_store_active_record
- we should remove deprecation warnings
- with 3.0 release, we change the dependency to
ruby_event_store-active_record
. It would be nice (but not mandatory) to also release 3.0 for bothruby_event_store-active_record
andrails_event_store_active_record
(and 3.0 being the last version of this one). Then people not using rails_event_store could make gradual change (since they have to explicitly specifyrails_event_store_active_record
if they use it)
I don't see other reason since we can't say "either that gem or this gem" in gemspec, or "if we have ruby_event_store-active_record, then we rails_event_store_active_record is no longer dependency".
I don't see value in deprecation warnings in 2.x, even if it would be last version of 2.x. Unless people can actually solve the deprecation (by using newer version), but they can't (they can only do that when being on 3.0, without rails_event_store).
from rails_event_store.
from rails_event_store.
Correct me if I'm wrong. As of now:
rails_event_store-2.6.0
depends onrails_event_store-2.6.0
rails_event_store-master
depends onruby_event_store-active_record-master
We did it because we control this dependency and replaced internally all invocations of RailsEventStoreActiveRecord
with RubyEventStore::ActiveRecord
.
We're also providing rails_event_store_active_record
gem that:
- has dependency to
ruby_event_store-active_record
- aliases
RubyEventStore::ActiveRecord
asRailsEventStoreActiveRecord
- warns about rename in post-install message and when requiring
rails_event_store_active_record
The only reason this aliased gem exists is for someone directly depending on it (which we don't control).
There's also the case of documentation pointing to RailsEventStoreActiveRecord
, which we don't want to change in 2.x. Also someone might have customized RailsEventStoreActiveRecord
so this const being stil present is fair expectation.
Should we then keep rails_event_store
to depend on rails_event_store_active_record
, being a wrapper on ruby_event_store-active_record
? Do we hide deprecation warnings? Do we need to mention this deprecation in the docs?
from rails_event_store.
Related Issues (20)
- AfterCommitAsyncDispatcher does not pass event to custom scheduler HOT 3
- Unexpected handling of empty array when link-ing using AR repo HOT 2
- Add railtie server block for outbox
- Test outbox compatibility with sidekiq 7.0 HOT 1
- Store commit ID (transaction ID) in metadata
- Serializing event types from Dry::Struct events HOT 1
- ActiveJobScheduler does not stringify payload keys and triggers warning in Sidekiq
- Redesign event page HOT 2
- Test on truffleruby HOT 2
- Use of mutation testing in rails_event_store - Help needed
- ActiveRecord and the need of non-serialized data and metadata for JSONB HOT 1
- Repository for MySQL 8.0 using NOWAIT (and possibly PostgreSQL) HOT 1
- Generate test workflow YAMLs from templates
- RES ActiveRecord uses unnecessary join HOT 5
- Unable to update to rails_event_store 2.8 HOT 3
- RubyEventStore::Projection does not yield events in deterministic order when using multiple streams HOT 2
- Improve RES projections
- Migration guide to RailsEventStore::JSONClient HOT 3
- Create new release for `ruby_event_store-rom` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails_event_store.