Comments (3)
Does it assume you always append one event, as in the examples? If it allows many events, does it group them by streams and executes multiple appends — one per stream?
My gut feeling is — this is fine for a framework on top of RES. And then perhaps a definition of go-to stream should be close to the definition of the event.
from rails_event_store.
Does it assume you always append one event, as in the examples? If it allows many events, does it group them by streams and executes multiple appends — one per stream?
I was thinking that there's no need to consider multiple events when doing StreamsNameProvider#call
, but it can be interesting idea to put the grouping logic (which I can imagine, there can be more than one), into StreamsNameProvider
default implementation. So actually, idd, I'd change the API to #call(events)
My gut feeling is — this is fine for a framework on top of RES.
Where is it then (that framework
)? I see ourselves blocking from implementing multiple slightly opinionated aspects of event-driven library (versioning, data
structure validation, this issue) because it won't fit the RES-core (so to speak), and in the meantime these will likely get reimplemented in each project. And being able to specify (any implementation of) StreamsNameProvider
isn't even that opinionated 🙃
I don't see a problem in reimplementing per se (we don't owe anyone particular features), but with that we're blocking ourselves from implementing smarter RES-Browser. It won't be easy to implement some, for example, versioning functionality on the browser without at least providing some commonly agreed API on it (like "What was the previous version of that event?").
And then perhaps a definition of go-to stream should be close to the definition of the event.
That I agree, the example was just to be simple example, but #call
can do anything having event object at hand
from rails_event_store.
As an additional highlight, if you're worried about backwards compatibility, we may mark this as experimental feature for some time: https://railseventstore.org/docs/v2/maintenance_policy/#experimental-features
from rails_event_store.
Related Issues (20)
- Migration guide to RailsEventStore::JSONClient HOT 3
- Create new release for `ruby_event_store-rom` HOT 1
- can't write unknown attribute `event_id` HOT 2
- ruby_event_store-browser 2.10 undefined method `match?' for nil:NilClass HOT 4
- Making the broker configurable HOT 3
- Unsupported adapter when running migration (2.11.1) HOT 6
- Rspec issue when testing with have_subscribed_to_events HOT 5
- NoMethodError when using `RubyEventStore::RSpec::Publish` matcher with `InMemoryRepository` and preceding events HOT 3
- Documentation on Postgres jsonb serialization is not consistent HOT 1
- Projection does three (3) queries where it could be doing one (1) HOT 3
- Browser timezone HOT 3
- Document our approach to semver and backwards compatibility
- The provided template for existing rails application doesn't work for rails_event_store 2.14.0 and rails 7.1.2 HOT 2
- Allow specifying index HOT 2
- InvalidAuthenticityToken HOT 2
- Timezones not working (for me)
- Generated migration is not Strong Migrations compatible HOT 2
- Potential issue with expected version while publishing events HOT 1
- JSONB variant should make use of GIN indexes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails_event_store.