Giter Site home page Giter Site logo

Vicky 3 dates parsed wrong about cli HOT 3 CLOSED

Groogy avatar Groogy commented on August 22, 2024
Vicky 3 dates parsed wrong

from cli.

Comments (3)

nickbabcock avatar nickbabcock commented on August 22, 2024

Ah, the heuristic if a date is present fails on 1.1.1 (which is encoded as 43808760), as the heuristic says "hey, we're playing vic3, anything that decodes to a pre-1700 date must not be a date".

Thanks for the report, I'll push out a fix in a couple hours.

from cli.

nickbabcock avatar nickbabcock commented on August 22, 2024

I cut v0.4.6, which should have this fix in there (needs a few more mins to show up in github releases).

Let me know how it goes 😄

I don't think it's perfect yet, as there are some game state models that have a slightly different fixed / floating point encoding than others (like the _strength fields), but I haven't quite nailed down the pattern (it may literally just be anything that ends in _strength uses this alternative encoding). So in your travels if you come across, additional inconsistencies, let me know the pattern and I can adapt it.

EU4 spoiled me with consistent 32bit and 64bit fixed / floating point encoding

from cli.

Groogy avatar Groogy commented on August 22, 2024

Awesome thank you, will let you know when I do the next edit round for our mp game.

To go by what is fixed/floating point, you can use as a rule of thumb that if it is something that needs to be synced over the network it will be fixed point (i.e anything that affects gameplay), if it is cached values for the interface etc it will be a floating point

from cli.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.