style.css needs optimisations

[ramiismail]

style.css needs optimisations

[adnissen]

I might take a shot at fixing this, I have a little experience with responsive web design. I'll take a look.

[DaveVoyles]

Sounds like it needs a media query. Bootstrap has excellent examples of
this , for all screen sizes.

On Thursday, November 28, 2013, Andrew wrote:

I might take a shot at fixing this, I have a little experience with
responsive web design. I'll take a look.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-29475134
.

[Dearon]

@DaveVoyles Using Bootstrap itself might be a bit overkill for this however. Seems like Susy or Pure might be better options. I'll also take a look at this when I have the time if no one else has made any changes yet.

[DaveVoyles]

Oh I agree.

I was only suggesting that we take a look. At how bootstrap handles the
queries, and mimicking that, as it works so well across all resolutions.

On Thursday, November 28, 2013, Dearon wrote:

@DaveVoyles https://github.com/DaveVoyles Using Bootstrap itself might
be a bit overkill for this however. Seems like Susyhttp://susy.oddbird.net/or
Pure http://purecss.io/ might be better options.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-29490769
.

[Dearon]

@ramiismail I've made a bunch of changes to the html and css to make it responsive and such, is it alright like this?:

The first part of the install, the second part of the install and the main page (using Vlambeers info to give a better idea of what it looks like).

[ramiismail]

Wow, that's pretty good, thanks so much! A little extra margin-top on
"Contact" would be amazing. I'll merge it in after that.

On Sat, Nov 30, 2013 at 9:02 PM, Dearon [email protected] wrote:

@ramiismail https://github.com/ramiismail I've made a bunch of changes
to the html and css to make it responsive and such, is it alright like
this?:

The first part of the installhttp://jsfiddle.net/Dearon/VksTv/embedded/result/,
the second part of the installhttp://jsfiddle.net/Dearon/Lwqw3/embedded/result/and the
main page (using Vlambeers info to give a better idea of what it looks like)http://jsfiddle.net/Dearon/nV6cZ/embedded/result/
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-29559838
.

• www.vlambeer.com
• follow vlambeer on twitter http://twitter.com/Vlambeer or like us on
  facebook http://www.facebook.com/pages/Vlambeer/153601874671274

[Dearon]

I hadn't noticed that so I'll run through the pages again to see if there are other parts where the margin is off. After that I'll run through the PHP files since there are also a bunch of tweaks to the html (e.g. the inclusion of various CSS and Javascript libraries). Hopefully that's not going to take too much work :p

[ramiismail]

Does the kit render well on non-javascript devices, too?

[Dearon]

Yeah. The only difference is that the images are sorted the way they are through the Masonry library, so if you have Javascript disabled it looks a little bit ugly but still entirely functional. Aside from that the install/upgrade will obviously not work but that is due to the way it's designed.

Also a question, what is the file "archive/_template/index.php" used for? Index.php is clear, sheet.php too, but I haven't been able to figure out where that file is used.

[ramiismail]

They're not actually used, I'll remove them from the directory.

On Mon, Dec 2, 2013 at 8:46 PM, Dearon [email protected] wrote:

Yeah. The only difference is that the images are sorted the way they are
through the Masonry http://masonry.desandro.com/ library, so if you
have Javascript disabled it looks a little bit ugly but still entirely
functional. Aside from that the install/upgrade will obviously not work but
that is due to the way it's designed.

Also a question, what is the file "archive/_template/index.php" used for?
Index.php is clear, sheet.php too, but I haven't been able to figure out
where that file is used.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-29650731
.

• www.vlambeer.com
• follow vlambeer on twitter http://twitter.com/Vlambeer or like us on
  facebook http://www.facebook.com/pages/Vlambeer/153601874671274