Comments (6)
requirements.txt
is required for GitHub to generate dependency graphs. Github dependabot can alert us of any critical security updates in any package we depend on.
from notion-sdk-py.
IIRC dependabot can already parse setup.py. GitHub dependency graph is not really important to me, and I'd rather not duplicate the dependencies for this sole benefit. Although maybe it's smart enough to support a "fake" requirements.txt containing only something like -e .
?
from notion-sdk-py.
If requirements.txt
is there, then the developer can do
pip install -r requirements.txt
For the end-user, who will pip install notion-client
, this does not matter. But for people who will clone this repo, create a virtual env, and start developing, they need to need to manually install all required packages required by the notion-client
.
Currently notion-client
only depends on httpx
, (so i need to pip install httpx
) but in the future, as we provide more features, we may need other dependencies, then pip install x y z
may become cumbersome.
It will be great, if a contributing guidelines is written, for new developers who want to contribute to this repo.
from notion-sdk-py.
Yeah, I do agree that a requirements.txt file makes contributing easier by respecting people habits. :) What I don't want is to duplicate the list of dependencies, hence the -e .
suggestion, which I think would make everyone happy.
from notion-sdk-py.
yes, that's right. But once, editable installs are available for pyproject.toml
, I think, we should move to poetry.
from notion-sdk-py.
Yeah maybe, let's discuss it again when that happens. Thanks for your contribution!
from notion-sdk-py.
Related Issues (20)
- Sample query doesn't work, return empty result HOT 4
- [error] AttributeError: 'str' object has no attribute 'logger' HOT 2
- How to read the `block` text?
- Type hints HOT 2
- Logging configuration does not work HOT 2
- notion_client does not work in a class under multiprocessing HOT 2
- notion.databases.create: Is it possible to rearrange database fields according to some defined order? HOT 2
- Using asyncio for notion.pages.create requests HOT 1
- httpx 0.25.x is not compatible with notion client: "TypeError: ConnectionPool.__init__() got an unexpected keyword argument 'socket_options'" HOT 4
- Image upload error when create a new notion page HOT 1
- Alternative for `DatabasesEndpoint.list()` HOT 1
- Create database entry with `select` property HOT 1
- Deleting an icon or a cover is not possible.
- Switch to Ruff HOT 1
- iterate_paginated_api and api_endpoints#query seems to be broken in 2.2.0 HOT 3
- notion.blocks.append not accessible HOT 1
- Database query malformed schema HOT 1
- Wrong response when querying database rollup field with ascending/descending sort HOT 2
- Add Type Hints to Response and Arguments of a function HOT 1
- Allow to set the in_trash property of a page using notion.pages.update() HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notion-sdk-py.