Giter Site home page Giter Site logo

Comments (8)

rawmind0 avatar rawmind0 commented on August 29, 2024

This is not related with issue #12. rancher2_namespace and rancher2_project resources need that the cluster is active to be created.

Submitted PR #73, that adds wait_for_cluster argument on rancher2_namespace and rancher2_project resources to wait for cluster is active.

from terraform-provider-rancher2.

jnicholls avatar jnicholls commented on August 29, 2024

See my comment on PR #73. Beyond the rancher2_namespace and rancher2_project resources, there are other kubernetes-based resources which rely on the kube-apiserver being ready. It would be great to create a new type of resource named something like rancher2_cluster_wait_until_active that takes the cluster_id and an optional timeout, and will wait until the cluster's kube-apiserver becomes ready before proceeding. Then, kubernetes/helm/etc. resources can explicitly be set to depend upon that resource and will thus wait for it to return.

Thoughts?

from terraform-provider-rancher2.

josmo avatar josmo commented on August 29, 2024

Thanks @rawmind0!!

from terraform-provider-rancher2.

josmo avatar josmo commented on August 29, 2024

@jnicholls I like the proposal, I don't think it's a huge deal for namespaces and the likes in k8s resources since you could still use the rancher resources for that, however things like setting up volume classes that doesn't have deps on namespaces, starting in the system/default namesspaces, it would be really useful

from terraform-provider-rancher2.

narfeta avatar narfeta commented on August 29, 2024

hi all, any update about this? it would be really useful to have this feature.

from terraform-provider-rancher2.

drpebcak avatar drpebcak commented on August 29, 2024

I think it makes sense to have optional waits on all the rancher2 resources, but then also have something separate that can tell you if the cluster itself is ready, like rancher2_cluster_wait_until_active

from terraform-provider-rancher2.

rawmind0 avatar rawmind0 commented on August 29, 2024

I think that @jnicholls proposal is indeed moreover to "external" rancher2 resources. For rancher2 resources, not sure it it's needed on all, but PR #73 extra argument should be enough, due to they are able to check the cluster state.

from terraform-provider-rancher2.

rawmind0 avatar rawmind0 commented on August 29, 2024

Merged PR that address this issue. Please, reopen issue if needed.

@jnicholls, could you please open a new issue if you are still interested on your rancher2_cluster_wait_until_active proposal??

from terraform-provider-rancher2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.