Giter Site home page Giter Site logo

Comments (4)

RandyGaul avatar RandyGaul commented on June 12, 2024 1

Okay, sounds fine to me! PR is welcome.

from cute_headers.

RandyGaul avatar RandyGaul commented on June 12, 2024 1

Thanks for the help!

from cute_headers.

konsumer avatar konsumer commented on June 12, 2024

Some more notes on this:

I had a map that saved like this:

"objects":[
    {
     "class":"player",
     "gid":1,
     "height":16,
     "id":1,
     "name":"",
     "rotation":0,
     "visible":true,
     "width":16,
     "x":384,
     "y":352
    }
]

Not even quite sure how I managed to save this, but it made all my code looking for type not work, so I think it may be some older compatibility setting, in save. I didn't hand-edit or anything, just some option when saving in Tiled. The PR simply treats class as if it's type, since they seem to be interchangeable. Like this is the current format, without editing anything by hand, just re-saving it:

[
  {
   "gid":1,
   "height":16,
   "id":1,
   "name":"",
   "rotation":0,
   "type":"player",
   "visible":true,
   "width":16,
   "x":384,
   "y":352
  }
]

Tiled editor, itself, seems to do the same thing. I opened the file with class and it worked fine (showing in the UI as Class) then saved it in a different location, and it renamed it to type with all the data in the same place. When I open that fixed file again, it looks the same:

Screenshot 2023-10-15 at 11 05 24 PM

Now, that it's saved with type it's not really a big deal to me either way. Not totally sure how I managed to save it with class but the PR would make it work for both types of files, and doesn't break the old behavior.

from cute_headers.

konsumer avatar konsumer commented on June 12, 2024

I think the source of the prob is this:

type | string | The class of the object (was saved as class in 1.9, optional)

So, the field just got renamed in 1.9. Supporting both type and class and putting in type in the struct (as I do in PR) seems to be the correct behavior, to me.

from cute_headers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.