Nettle API breakage

[randyzwitch]

Nettle API breakage

[randyzwitch]

Thanks for the heads-up; whenever you've finalized your changes, I'll incorporate them here. Luckily, this package is pretty small.

[staticfloat]

The changes are finalized, feel free to change your package whenever you are ready. :)

[randyzwitch]

What do I need to do, work off of master, then specify a version number in REQUIRES?

On Sep 21, 2015, at 5:39 PM, Elliot Saba [email protected] wrote:

The changes are finalized, feel free to change your package whenever you are ready. :)

—
Reply to this email directly or view it on GitHub #7 (comment).

[staticfloat]

Precisely.

[randyzwitch]

Maybe I'm missing something, but did you change the API for the code usage I do? The README documentation appears to be the same.

https://github.com/randyzwitch/OAuth.jl/blob/master/src/OAuth.jl#L38-L43

https://github.com/randyzwitch/OAuth.jl/blob/master/src/OAuth.jl#L109-L113

[staticfloat]

In your case, you need to change HashState to Hasher, and I think that's it! Super simple!

[staticfloat]

Oh, one other thing; SHA1 needs to become "SHA1". Notice the quotes; there aren't per-hash types anymore; we do things with strings now.

[randyzwitch]

Ah, staring at code too long today already, I missed the quotes!

[staticfloat]

Once JuliaLang/METADATA.jl#3537 is merged, this package's Nettle functionality will cease to work. I've opened a pull request to this repository with the necessary fixes.

[randyzwitch]

There was an error during the PR checks, is that because JuliaLang/METADATA.jl#3537 hasn't been merged?

[staticfloat]

Yes, exactly. Once you merge into your master branch, I'll release Nettle
v0.2.0, then you can ensure everything works on master and release a new
version.

On Sat, Sep 26, 2015, 5:36 PM Randy Zwitch [email protected] wrote:

There was an error during the PR checks, is that because
JuliaLang/METADATA.jl#3537
JuliaLang/METADATA.jl#3537 hasn't been merged?

—
Reply to this email directly or view it on GitHub
#7 (comment).