Comments (11)
Hey @Cthutu pushed a correction for those issues in 3b482ff. Please pull latest main and check if still happens.
I will close this issue after validate the fix with @filaruina
from rio.
Your changes fixes the first issue (woohoo!). However, it doesn't render correctly on a tiled window manager (the window opens at the usual size then immediately gets resized and repositioned by the desktop manager) or when you resize the window (e.g. maximising). I think this is just because you don't redraw on resize in the demo? I haven't had enough time lately to get to the bottom of it.
from rio.
Yes, that's "expected" (not a bug) in demo since it only listen to ScaleFactor updates but is ignoring resize events without scale factor updates. Would be good to add it to the examples.
Also, I think it happens the same for rect case when happens a resize:
![Screenshot 2023-05-26 at 09 59 53](https://private-user-images.githubusercontent.com/3630346/241157094-b876a8ec-a7da-43c8-91f1-54d8c34b54ee.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE4MTE5NDAsIm5iZiI6MTcyMTgxMTY0MCwicGF0aCI6Ii8zNjMwMzQ2LzI0MTE1NzA5NC1iODc2YThlYy1hN2RhLTQzYzgtOTFmMS01NGQ4YzM0YjU0ZWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjRUMDkwMDQwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDYxMDUwYTQ0Y2JjZjBiZjQ5MzUyMjAxNmE0MmExOGZlMTA5ZmQ3Y2Q1ZjM0YTQ4Mzg0M2RiNGQyN2RiYTY1MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.fSwYsyYkcqwOFbvDS0wWTm6netvZdiI7YcvXhNJhJ7I)
For now I will close this issue but feel to update the examples 🙏
Other thing to take in consideration is the examples are using fixed LogicalSize, idk how it behaves in Linux (considering test PhysicalSize instead)
from rio.
This is the result of the rect.rs
example. I am not sure if it's correct:
It also suffers from resizing problems.
from rio.
Hey there @Cthutu , yes I am aware (unfortunately). Same behaviour happens in the macos when having an external monitor with a scale factor different than 2.0. The initial render of sugarloaf has a hardcoded logic to start calculating layouts with 2.0, this need to be fixed.
Rect is the only case that's correct because doesn't the scale calculation.
from rio.
I plan to look on that soon, but feel free to send a PR as well 🙏
from rio.
BTW same happens to Rio in macos when using external monitor with 1.0 scale factor.
from rio.
If you want pixel perfect you should be using PhysicalSize. If you want to take into account the user's settings for monitor scale factors etc, LogicalSize is your friend.
from rio.
Yea, I like LogicalSize for the terminal as an user application but thinking in enable it as configuration option, then you can choose what fits better for your case.
from rio.
BTW same happens to Rio in macos when using external monitor with 1.0 scale factor.
This is fixed for me using main version. Running on ubuntu
from rio.
Great, thank you @filaruina for testing it too !
from rio.
Related Issues (20)
- Rendering issues with vertical lines HOT 1
- [Bug] Rendering freezes quickly after starting HOT 3
- Application crash if dump the content of binary file HOT 1
- Can't `SelectPrevTab` in breadcrumb navigation mode HOT 5
- Any interest in supporting stylistic-sets and/or character variants? HOT 1
- [Feature Request]: Support find in the terminal HOT 2
- `editor` doesn't handle arguments
- Allow specifying font features HOT 1
- [Linux] Color automation does not work
- [Windows]Abnormal font display and incomplete Navigation content display HOT 3
- thread 'main' panicked at /sugarloaf/src/context/mod.rs:100:14 HOT 3
- macOS: Rendering gets slow when going full-screen on an external 4K monitor HOT 1
- macOS 15 beta 2: Rio crash, not opening HOT 1
- Crash on startup in ubuntu 24.04 HOT 1
- Computer slows down when running mpv over a mounted sshfs folder HOT 2
- [Bug] sequence `CSI K` to work incorrectly HOT 2
- Configuration for last window close behaviour HOT 2
- No input after first run HOT 3
- (Bug) Rio block the keyboard shortcuts from the desktop environment on Wayland HOT 1
- can not input chinese HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rio.