f1-3-c2p1-colmar-academy's People
f1-3-c2p1-colmar-academy's Issues
Great! Comments
https://github.com/Raphg27/f1-3-c2p1-colmar-academy/blob/master/capstone/index.html#L11
Nice organizational comments, these really help in readability for both me and you.
Error. Nav
https://github.com/Raphg27/f1-3-c2p1-colmar-academy/blob/master/capstone/index.html#L26-L31
Seems your mobile nave never shows up no matter how small I make the page. Make sure and test your media queries as you write them so your displays work properly.
Great! CSS Organization
https://github.com/Raphg27/f1-3-c2p1-colmar-academy/blob/master/capstone/resources/css/style.css#L1
Your comments, spacing and indentation help keep your CSS organized for my reading and your work.
SUMMARY
Grade: Satisfactory
Summary:
Your code here is well organized, overall a nice job. Your implementation of mobile resizing seems nonexistent though, which is a bit of a problem. It seems either your media queries aren't firing, or the code within them isn't doing much. Make sure to test your site at all sizes possible to ensure it's working, and use chrome developer tools to get a sense of what's going wrong: https://developer.chrome.com/devtools
Once your resizing kinks are worked out, make sure to try adding some personal flair to the site. You can check out this site to get some ideas of modern web design patterns. http://www.webdesign-inspiration.com/web-designs/style/modern
Simplify. Spacing
https://github.com/Raphg27/f1-3-c2p1-colmar-academy/blob/master/capstone/index.html#L60-L75
Some unnecessary spacing here, only use spacing to separate large sections of code.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.