Giter Site home page Giter Site logo

Comments (4)

jhart-r7 avatar jhart-r7 commented on June 3, 2024

In general I'd agree with what you've suggested. If it is possible to write a fewer number of fingerprints (ideally just 1) for each product with careful grouping, then absolutely do it if you have <examples> showing that the regex works and extractions happen as expected.

from recog.

jhart-r7 avatar jhart-r7 commented on June 3, 2024

Also, I think https://github.com/rapid7/recog/blob/master/README.md could/should be updated to describe our preferences around the regular expressions. @inokii, if you'd like to take a pass at updating it via a PR that would be great!

from recog.

inokii avatar inokii commented on June 3, 2024

Added Best Practices section to README.md per your suggestion. Opened PR #34. I'm hoping to find some free time over the next week to make updates to the 19 patterns I mentioned, and will submit PR after testing.

from recog.

jhart-r7 avatar jhart-r7 commented on June 3, 2024

Landed #34. Thanks for the contributions!

from recog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.