Giter Site home page Giter Site logo

Comments (4)

RashKash103 avatar RashKash103 commented on August 17, 2024

I will have a look at that and see what might be causing the issue.

Thanks for opening up a PR on the Windows requirements!

from custom-gridfinity-bins.

RashKash103 avatar RashKash103 commented on August 17, 2024

@bitranox โ€“ so looking into the code, I realized that it was a design decision that I made to make the front wall thicker, even if the finger scoop was disabled. This is what it currently looks like:

Current front wall picture

And you're requesting to make it look like this:

Proposed front wall picture

I believe that if that is what you proposed, it might be difficult to lift up items using the front surface as leverage since they would get stuck on the lip. This is especially noticeable when using smaller sections because you don't need leverage to lift up components from a larger section. Therefore, that is intended behavior.

That being said, I will work on adding a configuration option to remove that padding if the finger scoops are disabled.

from custom-gridfinity-bins.

bitranox avatar bitranox commented on August 17, 2024

Dear RashCash,
first of all - great work and thank You for Your kind response!

I believe that if that is what you proposed, it might be difficult to lift up items using the front surface as leverage since they would get stuck on the lip.

Absolutely true for smaller Trays - I have some trays where that does not matter, so it is a waste of material.
You can also make the angle of the lower chamfer on the front lip a bit less steep to ease that problem.

proposed Settings :

# FRONT Lip lower chamfer angle, between 0 and 60 degrees for easy parts removal
# the lower the angle, the easier to extract and pour out, but needs more material. Default = 45 degrees
# this setting applies only to the front lip and makes only sense when FRONT_WALL_PADDING = False
LIP_FRONT_LOWER_CHAMFER_DEG = 30

# Lip lower chamfer angle, between 0 and 60 degrees for easy parts pouring out on small parts
# the lower the angle, the easier to pour out, but needs more material. Default = 45 degrees
# this setting applies to all lips, except the front lip
LIP_LOWER_CHAMFER_DEG = 45

# make FRONT wall thicker to match the Lips nose - for easy parts removal, but needs more material, 
# Default = True
# this setting applies only to the front wall and only makes sense when DRAW_FINGER_SCOOP = False
FRONT_WALL_PADDING = False           

# make wall thicker to match the Lips nose - for easy parts pouring on very small parts, but needs more material
# Default = False
# this setting applies to all walls, except the front wall.
WALL_PADDING = False           

the drawings You made are nice - lets put them to the readme section to explain the settings ?

and lets rename, that would be the correct terminus technicus :

# The number of Gridfinity units long (front to back)
UNITS_LONG = 1
# to 
# The number of Gridfinity units depth (front to back)
UNITS_DEPTH = 1

If You want to integrate, I can make more PRยดs for testing, clean CLI Interface, correct typing, etc ...

again - great work !

yours sincerely

Robert

from custom-gridfinity-bins.

bitranox avatar bitranox commented on August 17, 2024

Dear RashCash,
are You working on it ? Or should I ... ?
yours sincerely
Robert

from custom-gridfinity-bins.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.