Add getter to get *logrus.Logger object of `salt/log`

[mabdh]

Add getter to get *logrus.Logger object of `salt/log`

[mabdh]

@rohilsurana i see, sounds good. should we do that approach for now (for logrus only) ?

[rahmatrhd]

what if we also add a similar getter method in the Logger interface that returns interface{}. The user can cast it to the specific logger instance that they're using either it is logrus, zap, or anything else.

[mabdh]

@rahmatrhd I was also thinking that approach as the alternative but returning interface in interface does not looks solid to me personally. But if everybody is okay with that, it is fine.

[kushsharma]

I think its better to not modify the interface because at least the usecase mentioned by @mabdh doesn't really need it, we can get away by providing a getter in Logrus struct. One more thing I noticed in grpc_middleware is grpc_logrus can take *logrus.Entry so should we instead create a NewEntry method in Logrus to avoid users modifying core struct?

[mabdh]

@kushsharma yes, returning *logrus.Entry would be more appropriate IMO.

[rohilsurana]

For this specific case *logrus.Entry might suffice.

But for a larger discussion I think we should instead go for more of an injecting approach, where we can inject our own logrus.Logger instance if needed to initialise. We could use an option for doing this, like -

func LogrusWithLogger(logger *logrus.Logger) Option

This allows us to apply our defaults/options onto the logger as well as keep an handle of it to use it elsewhere or even modify its properties.

We could follow same pattern for other loggers for a similar looking API for all loggers.

[mabdh]

@rohilsurana even if we do so, how does it solve the problem

we want to get `*logrus.Logger` from salt `log.Logger`

?

Because the log.NewLogrus will only return the wrapper of *logrus.Logger which is *log.Logrus

[rohilsurana]

We keep a pointer to the injected logrus.Logger on our side and use it.