csharp-ls seems to conflate definition with implementation?

[razzmatazz]

csharp-ls seems to conflate definition with implementation?

[josteink]

Looking at the code that does indeed seem to be the case:

csharp-language-server/src/CSharpLanguageServer/Server.fs

Lines 685 to 686 in 242409a

	|> Map.add "textDocument/definition" (handleTextDocumentDefinitionOrImpl |> requestHandlingWithStateChange)
	|> Map.add "textDocument/implementation" (handleTextDocumentDefinitionOrImpl |> requestHandlingWithStateChange)

[razzmatazz]

Yeah, that was a cheap shot on my part to get something working but I didn’t get that much into semantic differences to realize it’s a bad idea :)

[josteink]

Fair enough. But IMO it's probably better/more correct to not advertise the "find implementation" capability until that is sorted out.

What do you think?

[razzmatazz]

oh definitely