Order of suggestions of code-fixes is not really optimized, especially with imports

[razzmatazz]

Order of suggestions of code-fixes is not really optimized, especially with imports

[razzmatazz]

pending on ionide/LanguageServerProtocol#4

[razzmatazz]

It looks like there is :) I thought there wasnt.

‘CodeAction.isPreferred’
https://microsoft.github.io/language-server-protocol/specifications/specification-3-17/#codeAction

[josteink]

On the same spec there’s also CodeActionKind:

kind?: CodeActionKind;

It seems one possible value for that is quickfix.

So I guess we should prioritise isPreferred and quickfix-kind actions, and in that order?

[razzmatazz]

pending on ionide/LanguageServerProtocol#4

ok, that one has been merged

[razzmatazz]

I have published 0.1.8, which should pull usings action up a bit, not 100% sure this was the right way to fix, as isPreffered was not taken into account in emacs-lsp/lsp-mode at the time I was checking it so not only that but I sorted simply those actions before returing to the editor -- hopefully ergonomics are better now

(it might take a couple of minutes for the package to show up on https://www.nuget.org/packages/csharp-ls/0.1.8)

[josteink]

Tested and works. Great stuff! 😃

Edit: Proof!

[josteink]

This works 100% as I described in the "expected" section in the issue, so I guess I have no choice but consider this 100% resolved 😄