Still getting 401 after Authentication Challenge

[rburgst]

Still getting 401 after Authentication Challenge

[rburgst]

can you see if this problem also persists with 2.1?

[zierka]

Ok, so it looks like it works for all subsequent requests (with 2.2 as well), just not with the first one (the first one that's sent with the Authentication header). It is correctly using the path component for the uri after that.

[rburgst]

Could you create a unit test that simulates the problem? There are already a couple of tests that you can use as a basis.

[zierka]

I can try. I forked the project, opened with Android studio and tried to run a test to see if everything's ok (by clicking the play icon next to the unit test method), but I always get No tests were found and Class not found: "com.burgstaller.okhttp.digest.DigestAuthenticatorTest". I'm unfortunately not that familiar with Android projects and Android Studio.

[zierka]

Upon further debugging, it looks like the issue exists only when using Charles Proxy. In that case route.requiresTunnel() returns true (proxy.type() == Proxy.Type.HTTP), so it enters the else case, where the host and port is used.

DigestAuthenticator:232

        // Add method name and request-URI to the parameter map
        if (route == null || !route.requiresTunnel()) {
            final String method = request.method();
            final String uri = RequestLine.INSTANCE.requestPath(request.url());
            parameters.put("methodname", method);
            parameters.put("uri", uri);
        } else {
            final String method = "CONNECT";
            final String uri = request.url().host() + ':' + request.url().port();
            parameters.put("methodname", method);
            parameters.put("uri", uri);
        }

I'm not actually sure if there is an issue with this library, if this is expected behaviour or not.

[rburgst]

I will need to double check this with a proxy setup, I will need to check #64 anyway.

[rburgst]

can you double check with the latest version, I fixed proxy authentication there.

[rburgst]

any news? can I close this?