Giter Site home page Giter Site logo

Comments (8)

Fireboltofdeath avatar Fireboltofdeath commented on July 17, 2024

What's your use case?

from core.

safazi avatar safazi commented on July 17, 2024

I meant server->client remote functions, wrote the wrong thing. There should be an option for the transformer to not generate the return type checking - the client can trust that the server will return what it is supposed to.

from core.

Fireboltofdeath avatar Fireboltofdeath commented on July 17, 2024

I meant server->client remote functions, wrote the wrong thing. There should be an option for the transformer to not generate the return type checking - the client can trust that the server will return what it is supposed to.

Is there a reason disabling the guards isn't viable? For example, introducing a settings to disable only return validation (but is there a reason to only disable return validation)?

from core.

safazi avatar safazi commented on July 17, 2024

Messed up again. I meant client -> server remote function invocation. Disabling the return guard is entirely viable (and I do that), but the server returns a big interface, and I'd rather it just not generate return type checking at all, especially as the interface gets larger and more complicated.

from core.

Fireboltofdeath avatar Fireboltofdeath commented on July 17, 2024

Messed up again. I meant client -> server remote function invocation. Disabling the return guard is entirely viable (and I do that), but the server returns a big interface, and I'd rather it just not generate return type checking at all, especially as the interface gets larger and more complicated.

Is your issue for cosmetic reasons or are you having issues with the size of the interface?

from core.

safazi avatar safazi commented on July 17, 2024

Cosmetic and efficiency. I am of the opinion that the client does has no reason to validate the servers return data at all.

from core.

Fireboltofdeath avatar Fireboltofdeath commented on July 17, 2024

Cosmetic and efficiency. I am of the opinion that the client does has no reason to validate the servers return data at all.

If guards are disabled on the client, it won't ever try to validate anything from the server.

I will take note of the cosmetic issues but that'll likely be addressed by #74 which won't inline the type guards

from core.

Fireboltofdeath avatar Fireboltofdeath commented on July 17, 2024

I am going to close this issue for now, if you think #74 isn't ideal for your use case then you can reopen but I believe it would solve the cosmetic issues you are concerned with.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.