Comments (8)
What's your use case?
from core.
I meant server->client remote functions, wrote the wrong thing. There should be an option for the transformer to not generate the return type checking - the client can trust that the server will return what it is supposed to.
from core.
I meant server->client remote functions, wrote the wrong thing. There should be an option for the transformer to not generate the return type checking - the client can trust that the server will return what it is supposed to.
Is there a reason disabling the guards isn't viable? For example, introducing a settings to disable only return validation (but is there a reason to only disable return validation)?
from core.
Messed up again. I meant client -> server remote function invocation. Disabling the return guard is entirely viable (and I do that), but the server returns a big interface, and I'd rather it just not generate return type checking at all, especially as the interface gets larger and more complicated.
from core.
Messed up again. I meant client -> server remote function invocation. Disabling the return guard is entirely viable (and I do that), but the server returns a big interface, and I'd rather it just not generate return type checking at all, especially as the interface gets larger and more complicated.
Is your issue for cosmetic reasons or are you having issues with the size of the interface?
from core.
Cosmetic and efficiency. I am of the opinion that the client does has no reason to validate the servers return data at all.
from core.
Cosmetic and efficiency. I am of the opinion that the client does has no reason to validate the servers return data at all.
If guards are disabled on the client, it won't ever try to validate anything from the server.
I will take note of the cosmetic issues but that'll likely be addressed by #74 which won't inline the type guards
from core.
I am going to close this issue for now, if you think #74 isn't ideal for your use case then you can reopen but I believe it would solve the cosmetic issues you are concerned with.
from core.
Related Issues (20)
- Compiled output is nonsensical HOT 1
- Macro nesting doesn't work if done between class methods
- Add a cleanup function for components, for when they are removed HOT 1
- Modding.Generic<T, "guard"> fails to pass nominal types due to intersection with primitives
- MacroManager could not find method for Vector2.idiv HOT 1
- Better runtime guards HOT 3
- "delete" keyword on Component attributes does not remove the attribute HOT 1
- offer @Decorator usage for events HOT 2
- Transformer option for automatic debug profiling HOT 2
- running npx rbxtsc -w results in a runInitalCompile error HOT 1
- Network batching HOT 2
- Flamework macros not working inside decorators HOT 1
- Allow us to configure obsfucation separately for networking and singletons/components HOT 2
- Disable networking client guards by default in production HOT 1
- Add double quotes to typeRoots
- Ability to create unreliable remote events HOT 1
- support bun HOT 1
- Write to `component.attributes` before firing `onAttributeChanged` signals
- Option to not obfuscate internal ids for server files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.