Comments (13)
@fritzZz Thanks for pointing out the issues with custom cards. I think the drag-n-drop feature is buggy when the card has custom template. Working on it.. will keep you posted
from react-trello.
Have rewritten most of the drag-n-drop logic to handle multiple cases. One know issue now is when you move a card from one lane to another, it will always be added to the end. That might be fixed in future. Other issues that you mentioned have been fixed.
You can test drag-n-drop with custom card templates here:
https://rcdexta.github.io/react-trello/?selectedKind=react-trello&selectedStory=Custom%20Card%20styling&full=0&down=0&left=1&panelRight=0
from react-trello.
I found a place where window is referenced loosely. v1.18.2 should fix it. Can you try again?
Right now, react-trello does not support injecting an external store. But it should be possible to dynamically add reducers to an existing store as discussed here: https://stackoverflow.com/questions/32968016/how-to-dynamically-load-reducers-for-code-splitting-in-a-redux-application
Pls feel free to make that change and submit a PR. Else will try to incorporate this feature sometime
from react-trello.
Thank you for your answer!
I tried also with the version v1.18.2 and I have the same problem.
Thank you for your suggestions also, I will try when the module will correctly work in my project.
from react-trello.
Sorry again! can you check with v1.18.3
from react-trello.
I found your fix but in my node_modules in the dist version of the react-trello library in my project I found this in the Board.js file
var store = (0, _redux.createStore)(_BoardReducer2.default, window && window.__REDUX_DEVTOOLS_EXTENSION__ && window.__REDUX_DEVTOOLS_EXTENSION__());
And the version is v1.18.2 in package.json
"raw": "react-trello@^1.18.2", "scope": null, "escapedName": "react-trello", "name": "react-trello", "rawSpec": "^1.18.2", "spec": ">=1.18.2 <2.0.0", "type": "range"
The problem occurs when I start webpack with my project in my local environment.
from react-trello.
yes i think you have frozen the package version to 1.18.2. Can you bump it to 1.18.3
from react-trello.
Ok! Thank you! Everything is working well now!!
I'm testing your Board and seems that custom cards have this 3 different "strange" type of problems:
- loose dragging when I pass on top of other cards and immediatly it starts again the dragging but replace with the card that was below
- get this kind of errors when I drag one card on top of the cards of another Lane and get strange beahaviours like duplicate empty slots when I drag or impossible to drugOut something and no empty slot appear.
Warning: flattenChildren(...): Encountered two children with the same key,
Card21. Child keys must be unique; when two children share a key, only the first child will be used.
Uncaught TypeError: Cannot read property 'id' of undefined at http://localhost:8079/assets/js/app.js:92940:21 at Array.map (native) at Lane._this.renderDragContainer (http://localhost:8079/assets/js/app.js:92938:76) at Lane.render (http://localhost:8079/assets/js/app.js:93026:15)
- One time I've lost one card (at the beginning cards were 4 but I ended with 3 cards)
Browser is Google Chrome Version 59.0.3071.115 (Official Build) (64-bit)
It also happens on your sample https://rcdexta.github.io/react-trello/?selectedKind=react-trello&selectedStory=Drag-n-Drop&full=0&down=0&left=1&panelRight=0
on firefox and chrome.
from react-trello.
I really want to use your component in my project so if you can "try" to give me more information about the progress of you bugfix I would be greatful!
I really don't want to push you too hard, I'm sorry!
Thank you in advance
from react-trello.
Hey @fritzZz. I am working on this issue this weekend and will be able to push something out by monday..
from react-trello.
Great! I will try it tomorrow!! :)
from react-trello.
Wow! Great job! It's working fine now!
Thank you very much!
from react-trello.
Glad to help. Thanks
from react-trello.
Related Issues (20)
- About add tags HOT 1
- LaneFooter not visible when there's no card in stack HOT 1
- Cannot read properties of null (reading 'trySubscribe') cause he above error occurred in the <Connect(BoardContainer)> component HOT 6
- react-trello-ts is now released :)
- LaneHelper.js:53 Uncaught TypeError: Cannot read properties of undefined (reading 'find')
- Dark mode
- Inner HTML in JSON
- Needs to be draggable by dragging on the body like trello.
- Broken on react 17 and 18
- Programmatically scroll within <Board> on a button click
- Bug when using hook react?
- Bug react hook useState, useEffect?
- How to listen for attribute updates on a Card? HOT 1
- Add treshold to infinite scroll
- Unable to try react-trello in a NextJS project HOT 1
- Drag-n-drop does not work correct in Firefox 119.0.1 (64-bit) Ubuntu
- Getting console warnings and errors with using the latest react-trello in my react app HOT 3
- Pass all "PickedProps" to all lane related Custom Components other than LaneHeader
- Plans for a headless version?
- index.js:1 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-trello.