Giter Site home page Giter Site logo

Comments (9)

WillsonHaw avatar WillsonHaw commented on August 24, 2024

Another one that was not polyfilled was createObjectURL. This is failing on my Tizen 2.4 device

from lightning.

WillsonHaw avatar WillsonHaw commented on August 24, 2024

For createObjectURL, it looks like it wasn't because of missing createObjectURL, but it is actually erroring with a Type Error when executing. It seems the mimetype passed to the function is causing the error. This was fixed for me by setting the type on the blob instead:

const blob = new Blob([code.replace('"use strict";', '')], { type: 'application/javascript; charset=utf-8' });
const blobURL = (window.URL ? URL : webkitURL).createObjectURL(blob);

from lightning.

g-zachar avatar g-zachar commented on August 24, 2024

I'm closing this issue for now, please reopen if still relevant.

from lightning.

markus101 avatar markus101 commented on August 24, 2024

I believe the change to _isNativeTexture would still be good to have, we can survive without the polyfills though.

from lightning.

g-zachar avatar g-zachar commented on August 24, 2024

Hey @markus101,

It's possible that webOS 2 was not taken into consideration back when Lightning was tested on variety of platforms in its earlier stages. Currently, we are not pursuing this target, however if you wish to contribute (looks like the solution is already there), we could consider adding the change to mainstream (including polyfills).

Best regards

from lightning.

markus101 avatar markus101 commented on August 24, 2024

This issue was originally regarding PS4, which didn't have issues rendering text and even with the polyfills above webOS 2 is unable to render text. I'm not sure this issue is related to #100.

from lightning.

g-zachar avatar g-zachar commented on August 24, 2024

Hi @markus101 ,

I see, since you commented on this issue I thought you've found your answer here. So, if I understood you correctly, the change and polyfills would fix problems on PS4 but webOS 2 is still open, correct?

Best regards

from lightning.

markus101 avatar markus101 commented on August 24, 2024

Correct, webOS 2 still has issues. I commented here because as far as I can tell the _isNativeTexture wasn't implemented and will still affect PS4.

from lightning.

g-zachar avatar g-zachar commented on August 24, 2024

@markus101 , thanks for clarification. We are not running any tests on PS4 neither, so if you wish to contribute a fix and can confirm it works on PS4 platform, we can include it in upstream. I'll reopen the webOS 2 issue then.

Best regards

from lightning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.