Giter Site home page Giter Site logo

Comments (10)

benjycui avatar benjycui commented on May 27, 2024 1

@shepherdwind I am not sure if we can pass rest props to panel?

collapse/src/Panel.jsx

Lines 14 to 22 in f6ea09b

className,
style,
prefixCls,
header,
headerClass,
children,
isActive,
showArrow,
destroyInactivePanel,

from collapse.

benjycui avatar benjycui commented on May 27, 2024

Nope, just use:

<Panel>
  <div id="..."></div>
</Panel>

from collapse.

mikhailChibel avatar mikhailChibel commented on May 27, 2024

@benjycui sure I can set id on the content of the panel. I would be nice to have an id of the panel itself, as it can simplify, for example, UI tests.

from collapse.

paranoidjk avatar paranoidjk commented on May 27, 2024

nope. There should never be a id api,but we may consider pass down rest props

from collapse.

shepherdwind avatar shepherdwind commented on May 27, 2024

Rest props pass to panel is ok. But, I think that React will throw error when pass an unknown prop to panel.

from collapse.

paranoidjk avatar paranoidjk commented on May 27, 2024

Rest props pass to panel is ok. But, I think that React will throw error when pass an unknown prop to panel.

IMO, This is not our concern, we just need to make sure all api which shown in doc are handled, then rest props should be all html valiad.

from collapse.

mikhailChibel avatar mikhailChibel commented on May 27, 2024

@benjycui Any hope on resolving this issue anytime soon?

from collapse.

benjycui avatar benjycui commented on May 27, 2024

ping @shepherdwind

from collapse.

shepherdwind avatar shepherdwind commented on May 27, 2024

Pass rest props to panel div will give it too much useless prop.

So, The only way is to add a prop id , see mr #72

from collapse.

shepherdwind avatar shepherdwind commented on May 27, 2024

1.7.6

from collapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.