Comments (10)
@shepherdwind I am not sure if we can pass rest props to panel?
Lines 14 to 22 in f6ea09b
from collapse.
Nope, just use:
<Panel>
<div id="..."></div>
</Panel>
from collapse.
@benjycui sure I can set id on the content of the panel. I would be nice to have an id of the panel itself, as it can simplify, for example, UI tests.
from collapse.
nope. There should never be a id api,but we may consider pass down rest props
from collapse.
Rest props pass to panel is ok. But, I think that React will throw error when pass an unknown prop to panel.
from collapse.
Rest props pass to panel is ok. But, I think that React will throw error when pass an unknown prop to panel.
IMO, This is not our concern, we just need to make sure all api which shown in doc are handled, then rest props should be all html valiad.
from collapse.
@benjycui Any hope on resolving this issue anytime soon?
from collapse.
ping @shepherdwind
from collapse.
Pass rest props to panel div will give it too much useless prop.
So, The only way is to add a prop id , see mr #72
from collapse.
1.7.6
from collapse.
Related Issues (20)
- Types don't seem to be in the npm package HOT 3
- Change header color using inline styling HOT 1
- How To Use openAnimation Property Properly HOT 2
- [A11Y] Add HTML tag "aria-hidden" HOT 1
- This style will cause me a bug
- Hide header option
- CSS not working even I import index.css following Readme HOT 1
- The lib folder is missing in the v2.1.0 package HOT 1
- 3.0.0 accordion collapse does not close HOT 1
- Is rc-motion slower?
- Mistake within the Documentation
- Migrate docs to dumi HOT 1
- [A11Y] Add "aria-disabled" attribute HOT 1
- how can i get panel header's clientHeight?
- CollapsePanel: onItemClick can not trigger HOT 1
- Is there a plan to change Class components to function components?
- Is there a plan to change Class components to function components? HOT 1
- Prop expandIcon does not have PanelProps which are mentioned on docs
- headerClass in Panel doesn`t work correctly HOT 2
- 什么**项目啊,compile直接报一大堆类型错误 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collapse.