Giter Site home page Giter Site logo

Comments (8)

vijayst avatar vijayst commented on June 28, 2024

@yesmeck @zombieJ -- is this something that should be fixed? I can do a PR if we need to have this prop.

from mentions.

zombieJ avatar zombieJ commented on June 28, 2024

Yes. PR is welcome. Let's use getPopupContainer instead. We use this in other rc-component. It's time to sync api.

from mentions.

vijayst avatar vijayst commented on June 28, 2024

I am not able to get npm start to work. Throws an error that it can't resolve 'core-js/...'. I am using Node 11.15.0.

from mentions.

zombieJ avatar zombieJ commented on June 28, 2024

Hmmm...remove all the lock file and use yarn to try again.

from mentions.

vijayst avatar vijayst commented on June 28, 2024

I could not resolve the rc-tools / core-js error. But here is the commit which will fix the issue:
https://github.com/vijayst/mentions/commit/3137fae40d87345d1b45c9ac6621fc5967456dfa

It is a simple change where there is a getPopupContainer prop passed to rc-trigger component.

from mentions.

zombieJ avatar zombieJ commented on June 28, 2024

You can PR for this since we have CI : )

from mentions.

vijayst avatar vijayst commented on June 28, 2024

PR - #10

from mentions.

vijayst avatar vijayst commented on June 28, 2024

PR - #12

from mentions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.