Improve Controller documentation

[react-hook-form]

Improve Controller documentation

[bluebill1049]

About what I just answered #779 (comment)

I think after some understanding that it's just a matter of doc 😅 Also giving less possibility is also less confusing.

Without deprecating the feature or remove it, we could just omit it in the doc, as we can achieve the same goals in one syntax. So why present two (the first one is a bit more confusion as props are getting overrided in all case

I think you are 100% right on that, it's my fault of lack of documentation! I will improve it over this week or the weekend. Feel free to leave some suggestions as well, as we can improve this together.

[ScreamZ]

About what I just answered #779 (comment)
I think after some understanding that it's just a matter of doc 😅 Also giving less possibility is also less confusing.
Without deprecating the feature or remove it, we could just omit it in the doc, as we can achieve the same goals in one syntax. So why present two (the first one is a bit more confusion as props are getting overrided in all case

I think you are 100% right on that, it's my fault of lack of documentation! I will improve it over this week or the weekend. Feel free to leave some suggestions as well, as we can improve this together.

Don't blame yourself, it's already huge to have developed this, I love writing doc, I'll give some help (already did :p) and it's always better when someone that hasn't the full experience and background on the lib that give feedback as you have more information than I :p

[bluebill1049]

To reduce confusion, only allows the <Controller as={Switch} /> syntax and remove the <Controller as={<Switch name="blabla" />} /> one, and always pass full props to that component ?

why there is a problem?

I see that the dependency has not been given.

I guess register and unregister should have name as deps, isn't? otherwise, we might experience a memory leak?

valid point. right now it's fine because useForm is handling all the cleanup

  if (!fields[name]) { //only reigster field once
    registerField();
  }

  // eslint-disable-next-line react-hooks/exhaustive-deps
  React.useEffect(() => () => unregister(name), []); // only run when component unmount

[ScreamZ]

About what I just answered react-hook-form/react-hook-form#779 (comment)

I think after some understanding that it's just a matter of doc 😅 Also giving less possibility is also less confusing.

Without deprecating the feature or remove it, we could just omit it in the doc, as we can achieve the same goals in one syntax. So why present two (the first one is a bit more confusion as props are getting overrided in all case

[bluebill1049]

we should add name in the dep tho, which you are correctly. I am slowly waking up now heheh

[bluebill1049]

Yea you are right! Thanks for contribution and all your feedbacks. They r really helpful not just for me and others after we improve the doc. I would love to see your avatar on our contribution list ;) so feel free send PR for things ❤️👌

Let’s keep this issue open, we can discuss while we making improvement on the doc.

[bluebill1049]

Just saw ur PR at the website. Awesome stuff approved and merged ❤️