Comments (7)
I think this is acceptabe.
For the sake of consistency please implement this using an emitter as i did
with the route change
On Sat, 30 Jan 2016 at 08:17, Eric Raio [email protected] wrote:
Currently, I have a redux/react application. I would love to be able to
respond to events whenever the router has pushed or popped an item on the
route stack.if this sounds acceptable, it's very easy to implement and i can submit a
pull request.—
Reply to this email directly or view it on GitHub
#15
.
from react-native-simple-router.
Yeah, that's what I was thinking, i'll submit a PR soon.
from react-native-simple-router.
@SEthX @charpeni
Hey guys, just catching up on the updates from #17
I like the idea better of using RN event emitter and replacing a dependency.
Yeah, I was wondering how to tap into navigators swipe to go back.
What's really nice about this approach is that it gives the developer the ability to add a ref to the router itself and respond to all push or pop events.
For people who use redux, they can maintain the state whenever a route changes if they chose to
componentDidMount() {
this.refs.router.emitter.addListener("push", (route) => {
// perform an operation for every push
})
}
render() {
return (
<Router
ref={"router"}
...
/>
);
}
from react-native-simple-router.
Looks good to me.
My thoughts were the same, so the router could be the central point where devs would attatch their event handlers relative to all things navigation to, kind of like a facade.
Who gets to implement this?
from react-native-simple-router.
@SEthX haha, I can research how to implement this, thought you had a design in mind 🎯
from react-native-simple-router.
I've been looking at this. Unfortunately pop/push and such do not emit events at a navigator level, and as such there is nothing to attach to.
Another solution is to use AOP and to use advice to have before/after such events.
I'll implement this and lets see how it behaves :)
I've been looking at https://www.npmjs.com/package/aspect-js to add support for this, does anyone have any opinion on it?
from react-native-simple-router.
Implemented this in #41
from react-native-simple-router.
Related Issues (20)
- Header: Back button text wraps HOT 5
- replaceRoute and resetToRoute No animation? HOT 1
- Twitter example red screen of death HOT 1
- Transition to another route with trans & hideNavigationBar & noStatusBar HOT 1
- multiple customAction in navigation stack
- LeftCorner in firstRoute
- "You are manually calling a React.PropTypes validation function for the..."
- custom navbar? HOT 2
- Trans:true no back button HOT 1
- Unable to fully hide navigation bar HOT 4
- Route management best practicies HOT 1
- Update NPM Version? HOT 2
- Show View after click on rightCorner icon
- make backbutton optional on android
- First Screen RIghtCorner Actions HOT 1
- Customize font for android navbar title HOT 2
- :bug: leftCorner offset titleComponent on Android HOT 1
- RightCorner doesn't work in firstRoute
- Trouble with sceneConfig HOT 2
- not supported by latest version of react-native HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-simple-router.