Giter Site home page Giter Site logo

Comments (4)

davidLeonardi avatar davidLeonardi commented on May 13, 2024

Feel free to make a PR :)

On Thu, Mar 3, 2016 at 3:30 PM Jeremy Greer [email protected]
wrote:

It would be nice to use an ID instead of name to identify routes. In some
cases, you'd want to use the same title for multiple routes. When observing
the routeEmitter, you only get the name (aka user-friendly title), so you
don't know which route was triggered.

For now, I'm using the titleComponent and titleProps to separate the name
from visible title. It works, but it's extra cruft.


Reply to this email directly or view it on GitHub
#90
.

from react-native-simple-router.

reergymerej avatar reergymerej commented on May 13, 2024

@SEthX done and done!

I left it open and just included the route in addition to the route name. This way, existing code won't break and devs can query whatever they want instead of introducing an id requirement.

from react-native-simple-router.

davidLeonardi avatar davidLeonardi commented on May 13, 2024

Please refer to discussion ongoing in #91

from react-native-simple-router.

charpeni avatar charpeni commented on May 13, 2024

PR #91 was merged, I'll close thank you @reergymerej.

from react-native-simple-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.