Comments (4)
Feel free to make a PR :)
On Thu, Mar 3, 2016 at 3:30 PM Jeremy Greer [email protected]
wrote:
It would be nice to use an ID instead of name to identify routes. In some
cases, you'd want to use the same title for multiple routes. When observing
the routeEmitter, you only get the name (aka user-friendly title), so you
don't know which route was triggered.For now, I'm using the titleComponent and titleProps to separate the name
from visible title. It works, but it's extra cruft.—
Reply to this email directly or view it on GitHub
#90
.
from react-native-simple-router.
@SEthX done and done!
I left it open and just included the route in addition to the route name. This way, existing code won't break and devs can query whatever they want instead of introducing an id
requirement.
from react-native-simple-router.
Please refer to discussion ongoing in #91
from react-native-simple-router.
PR #91 was merged, I'll close thank you @reergymerej.
from react-native-simple-router.
Related Issues (20)
- Header: Back button text wraps HOT 5
- replaceRoute and resetToRoute No animation? HOT 1
- Twitter example red screen of death HOT 1
- Transition to another route with trans & hideNavigationBar & noStatusBar HOT 1
- multiple customAction in navigation stack
- LeftCorner in firstRoute
- "You are manually calling a React.PropTypes validation function for the..."
- custom navbar? HOT 2
- Trans:true no back button HOT 1
- Unable to fully hide navigation bar HOT 4
- Route management best practicies HOT 1
- Update NPM Version? HOT 2
- Show View after click on rightCorner icon
- make backbutton optional on android
- First Screen RIghtCorner Actions HOT 1
- Customize font for android navbar title HOT 2
- :bug: leftCorner offset titleComponent on Android HOT 1
- RightCorner doesn't work in firstRoute
- Trouble with sceneConfig HOT 2
- not supported by latest version of react-native HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-simple-router.