Question: How will the iOS WebView differ from react-native-wkwebview

[f0rr0]

Question: How will the iOS WebView differ from react-native-wkwebview

[f0rr0]

Cool seems like the ball's in their court now. Hope they agree. I will close this thread.

[Titozzz]

FYI we did contact the authors to ask them if they wanted to contribute as we feel we would all benefit from one package instead of so many: CRAlpha/react-native-wkwebview#191. I will spend some time later to understand if there is still any benefits with using their package, and if so I'll try to implement it in the community package.

WebView being extracted from core does not mean it's support getting dropped, but instead easier contribution from the community

[satya164]

AFAIK React Native's WebView supported WKWebView when this was extracted, so it wasn't needed to look at other WkWebView implementations.

I think it's better to keep this implementation under react-native-community. It'll also be nice if the maintainers of react-native-wkwebview want to merge these projects into react-native-community/react-native-webview so that the work isn't split.

[f0rr0]

@satya164 @Titozzz thanks for replying so quickly (that too on a Sunday).

WebView being extracted from core does not mean it's support getting dropped, but instead easier contribution from the community

I am not worried about the support being dropped. Moving this out of the core seems to be a step in the right direction.

FYI we did contact the authors to ask them if they wanted to contribute as we feel we would all benefit from one package instead of so many: CRAlpha/react-native-wkwebview#191.

This is great. I hope the authors agree.

I will spend some time later to understand if there is still any benefits with using their package, and if so I'll try to implement it in the community package.

IMO their package is more feature rich. There seem to be issues here already referring to that other repo:

#38
#43

and if so I'll try to implement it in the community package.

In case the owners don't consent to unifying efforts into a single repo, does it make sense to fork the other repo under this organisation instead of implementing it here again or accepting PRs porting individual features?

#38 (comment)

[Titozzz]

I think porting individually we will the chosen solution, have you read https://facebook.github.io/react-native/blog/2018/08/27/wkwebview ? There has been a lot merged in 0.57 for the webview, which explains sticking to the react native original implementation. A lot of bug might a been fixed by the new implem, and our work initially here we be to review all the issues IMPORTED and make sure bugs still exists.

[jamonholmgren]

@f0rr0 Just FYI:

CRAlpha/react-native-wkwebview#191 (comment)

This project is licensed under MIT, so feel free to take part of the code or fork the whole project. And I am happy to direct the contributors to the new project.