Giter Site home page Giter Site logo

Comments (7)

brent-hoover avatar brent-hoover commented on September 12, 2024

Should things like Migrations and Job Control which don't currently have a UI still show up in the Permissions panel?

dumb_product

from reaction-admin.

spencern avatar spencern commented on September 12, 2024

I've thought about this as well, especially confusing where we have multiple permissions with the same name (Orders, orders, orders).

I also think we might need a "partial" state for the top level permission rather than on off. It's a bit confusing as to what the rule is when the top permission is on or off but subset of the underlying permissions are on/off.

from reaction-admin.

rymorgan avatar rymorgan commented on September 12, 2024

Totally agree, I've always thought this was confusing. It's also potentially dangerous b/c you don't know what permissions you are giving to certain users. I think it's ok to have permission groups of there are different parts of say, Analytics, you would want to allow permissions for certain users but it must be properly labeled.

I think that top level has to be a group. So you are giving permission to all of analytics to a user. Anything underneath would need to be a sub-grouping of analytics.

from reaction-admin.

brent-hoover avatar brent-hoover commented on September 12, 2024

I am classifying this as a bug but I feel like this needs to be a core bug because it probably involves implementing some new functionality? I'm adding this new label called "core-bug" which means the community team should leave it for core. If you disagree I'm fine with passing it back to us.

from reaction-admin.

spencern avatar spencern commented on September 12, 2024

@zenweasel I think we need some design direction along with some @reactioncommerce/architecture direction.

I agree that it's an area in need of some attention, and while it's not a feature request, it's more of a UIX bug than anything.

from reaction-admin.

brent-hoover avatar brent-hoover commented on September 12, 2024

Adding design tag to get design input

from reaction-admin.

brent-hoover avatar brent-hoover commented on September 12, 2024

Closing as this refers to an old version of the UI

from reaction-admin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.