Giter Site home page Giter Site logo

Comments (8)

mdiep avatar mdiep commented on April 28, 2024

Your best option is probably to use https://github.com/ReactiveCocoa/ReactiveObjCBridge/ with https://github.com/ReactiveCocoa/ReactiveSwift/

from reactiveobjc.

vitorhugomagalhaes avatar vitorhugomagalhaes commented on April 28, 2024

@mdiep Thanks for the comment.

I'm currently migrating to Swift 3 and that's the main reason for this errors. Still, it must be done.

The problem of using ReactiveObjcBridge + ReactiveSwift is the boilerplate of bridging we will have in the code. A lot of our swift code is exposed to Objective-C and that already sucks.

It could make sense to migrate everything to swift in the near future.

Meanwhile, I found that adding the explicit type seems to work. I still don't understand why it can infer the correct type since the RACObserve function returns a RACSignal type.

Regarding RACStream it does not implement lightweight generics. Is there a reason for it ?

BR,

from reactiveobjc.

andersio avatar andersio commented on April 28, 2024

/cc @erichoracek

from reactiveobjc.

vitorhugomagalhaes avatar vitorhugomagalhaes commented on April 28, 2024

I have divided the several signals to understand where the ambiguity occurs:

            let x1: RACSignal = self.RACObserve(self.settingsService.mib, "user_settings.pois.main_map_visible_categories")
            let x2: RACSignal<AnyObject>! = x1.ignore(nil)
            let x3 = x2.distinctUntilChanged()

Even by explicitly indicating the RACSignal type the compiler still founds it ambiguous.

from reactiveobjc.

erichoracek avatar erichoracek commented on April 28, 2024

This appears to be due to a Swift compiler issue that results from a method being declared both on a non-generic base class (RACStream), as well as on a generic subclass (RACSignal<ValueType>). Either of the following appear to resolve it:

  1. Declaring RACStream operations (e.g. distinctUntilChanged) as NS_SWIFT_UNAVAILABLE.
  2. Giving RACStream a lightweight generic ValueType annotation.

The second option appears to be the most preferable, since that leaves -[RACStream distinctUntilChanged] available to Swift consumers. Since the NS*/NSMutable* Foundation collections classes appear to work in ObjC and Swift with this pattern, I don't foresee there being an issue with attempting the second approach to fix this issue in RACObjC.

As such, unless anyone knows of any issues, I'll go ahead and make a PR with the second option.

from reactiveobjc.

erichoracek avatar erichoracek commented on April 28, 2024

@vitorhugomagalhaes please try 2.1.2 and make sure it resolves your issue. Let me know if it doesn't—thanks!

from reactiveobjc.

vitorhugomagalhaes avatar vitorhugomagalhaes commented on April 28, 2024

@erichoracek Thanks.

I will test the new version and get back to you asap.

from reactiveobjc.

erichoracek avatar erichoracek commented on April 28, 2024

I've filed this issue as https://bugs.swift.org/browse/SR-3529

from reactiveobjc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.