Giter Site home page Giter Site logo

Comments (4)

erichoracek avatar erichoracek commented on April 28, 2024

I've found in the past that when I'm bumping up against the time limits of the asynchronous... family of methods in tests, the solution is typically to attempt to speed up the test rather than increase the duration of the wait.

With respect to adding a new method, I'd learn towards actively discouraging long-running test methods in ReactiveObjC unless there's a very good use case for allowing custom wait durations.

However, if you absolutely need a longer timeout, it should be relatively easy to roll your own asynchronous... wait method as a RACSignal extension.

from reactiveobjc.

jcavar avatar jcavar commented on April 28, 2024

We are using it for performance testing with quite large data set, so we expect it to be longer then 10, especially on our Jenkins machines that are relatively slow.

But regardless of that I think allowing to pass dependency is generally good idea. Someone maybe needs shorter time interval. And we can still keep default value 10.

from reactiveobjc.

erichoracek avatar erichoracek commented on April 28, 2024

That use case seems like something that could be supported by ReactiveObjC if you'd want to take a stab at it. We'd likely want to keep the original asynchronous... methods but add another set that takes an extra timeout:(NSTimeInterval) for backwards compatibility.

from reactiveobjc.

jcavar avatar jcavar commented on April 28, 2024

Yes, that makes sense. Cool, I will then work on this when I have some free time and will post PR.

from reactiveobjc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.