Giter Site home page Giter Site logo

Comments (8)

RLittlesII avatar RLittlesII commented on April 20, 2024 1

@Kavignon What @glennawatson is most likely pointing out is that the sample is old. ReactiveUI has a healthy release cadence. There is the potential that the sample no longer works with/targets the current version of the framework. Which would indicate that there have potentially been breaking changes since this sample was created. So the "maintenance burden" he is referring to is keeping the samples relevant given the release cadence.

Given that there is still a packages.config that points to older framework versions, I would wager that's what he's referring to.

<packages>
<package id="Expression.Blend.Sdk" version="1.0.2" targetFramework="net45" />
<package id="FsXaml.Wpf" version="0.9.9" targetFramework="net45" />
<package id="reactiveui-blend" version="6.1.0" targetFramework="net45" />
<package id="reactiveui-core" version="6.1.0" targetFramework="net45" />
<package id="Rx-Core" version="2.2.5" targetFramework="net45" />
<package id="Rx-Interfaces" version="2.2.5" targetFramework="net45" />
<package id="Rx-Linq" version="2.2.5" targetFramework="net45" />
<package id="Rx-Main" version="2.2.5" targetFramework="net45" />
<package id="Rx-PlatformServices" version="2.2.5" targetFramework="net45" />
<package id="Rx-XAML" version="2.2.5" targetFramework="net45" />
<package id="Splat" version="1.5.1" targetFramework="net45" />

from reactiveui.samples.

open-collective-bot avatar open-collective-bot commented on April 20, 2024

Hey @Kavignon 👋,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially.

https://opencollective.com/reactiveui

PS.: We offer priority support for all financial contributors. Don't forget to add priority label once you start contributing 😄

An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!

from reactiveui.samples.

glennawatson avatar glennawatson commented on April 20, 2024

There is a bit of a maintenance burden so ideally if you get the samples up and running you'll have them working in the sln file.

from reactiveui.samples.

Kavignon avatar Kavignon commented on April 20, 2024

Are you saying that the samples are broken? @glennawatson

from reactiveui.samples.

Kavignon avatar Kavignon commented on April 20, 2024

@RLittlesII Ok I see! I'm not that familiar with .NET Core, package.config isn't suppose to be found any more?

I'm guessing here, my PR should remove the maintenance issue and make sure those samples are brought up to date with the current APIs?

from reactiveui.samples.

glennawatson avatar glennawatson commented on April 20, 2024

They replaced the packed.config with PackageReference.

Just a lot cleaner since it handles dependency packages.

from reactiveui.samples.

RLittlesII avatar RLittlesII commented on April 20, 2024

@Kavignon I would think that satisfying this issue would be to either create a new sample, or bring the old sample up to date.

I'd assume a potential task list of:

  • Update to the current version of ReactiveUI
  • Resolve any compilation issues
    • This will most likely be easier moving to PackageReference
  • Build and execute the sample
  • Verify the samples functionality works as expected

Yes. In the .NET Core space packages.config has been replaced with PackageReference in the .csproj file. I can tell the sample is old because of the existence of the file, and the references to Rx 2.2.5. The current version of System.Reactive is 4.1.6

More on Migrating to PackageReference

from reactiveui.samples.

github-actions avatar github-actions commented on April 20, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from reactiveui.samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.