Giter Site home page Giter Site logo

Comments (8)

clairernovotny avatar clairernovotny commented on May 5, 2024

Looking into this. If we can get the fully qualified type name, we can use the global:: syntax for it. It'll be ugly as hell in the generated code...but oh well.

from refit.

bennor avatar bennor commented on May 5, 2024

Doesn't full qualifying the types on the interface itself fix it? I think we use them as-is, so that should pass as a workaround.

How much time will coverting the syntax tree to a semantic tree add to builds (especially for big projects)?

from refit.

clairernovotny avatar clairernovotny commented on May 5, 2024

Check out my branch with the repro. It's not the interface it's the parameters to the methods.

So
namespace 1: MyType
namespace 2: MyType

namespace Services
file IMyService1.cs: IMyService1, in the file has using namespace 1. then Task Foo(MyType blah)
file IMyService2.cs: IMyService2, in the file has using namespace 2. then Task Foo(MyType blah)

Barf.

from refit.

bennor avatar bennor commented on May 5, 2024

Yeah, I mean can't you fully qualify MyType in the interface definition?

public interface IMyService1
{
    Task Foo(Namespace1.MyType blah);
}

from refit.

clairernovotny avatar clairernovotny commented on May 5, 2024

You have to do that for both interfaces....it's a workaround that works, but it's nasty.

from refit.

clairernovotny avatar clairernovotny commented on May 5, 2024

Ok, so I don't want to hold you up @bennor if you want to take a stab at fixing this; I probably won't have time to do more on it this weekend.

Checking out this PR and using "..\..\..\Refit-Tests\RefitStubs.cs" as the command line args to the InterfaceStubGenerator should make it easy to debug though.

from refit.

bennor avatar bennor commented on May 5, 2024

Will have a look a bit later on today if I get time. 👍

from refit.

flagbug avatar flagbug commented on May 5, 2024

RefitStubs.cs doesn't exist anymore, so this should be fixed

from refit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.