Overloaded method support

[reactiveui]

Overloaded method support

[bennor]

Yeah I was wondering about this when you added the warning for it. It adds a bit of complexity to RequestBuilderImplementation and the stub generation (and would mean a bit of duplication), but it would be good to allow the interface to match a Web API class almost 1 to 1.

@paulcbetts, can you think of any reason why this would be a bad idea?

[anaisbetts]

I'm not super excited about it, seems like a lot of added internal complexity. If I'm wrong though I'd take a PR!

[mburbea]

I think it can be resolved in the template generator. Simply assign a unique ordinal to each method by changing this line...

            ret.MethodList = interfaceTree.Members
                .OfType<MethodDeclarationSyntax>()
                .Select((x,i) => new MethodTemplateInfo() {
                    Name = x.Identifier.ValueText,
                    ReturnType = x.ReturnType.ToString(),
                    ArgumentList = String.Join(",", x.ParameterList.Parameters
                        .Select(y => y.Identifier.ValueText)),
                    ArgumentListWithTypes = String.Join(",", x.ParameterList.Parameters
                        .Select(y => String.Format("{0} {1}", y.Type.ToString(), y.Identifier.ValueText))),
                    IsRefitMethod = HasRefitHttpMethodAttribute(x),
                    MethodNumber = i,
                })

Something like that. Then Maybe switch to an array. And have each method stub lazily initialize itself. Or alternatively come up with a way to do the methodinfo reflection in a safe way. I don't know enough about the gimped TypeInfo version of reflection otherwise I might do it myself.
(Change the ToDictionary to a bunch of calls to Add passing in the appropriate ordinal.)

[nekresh]

I used something similar using mangled method names instead of method number.
It is still a Dictionary but I think it will be more readable and debug-able.