Splat's DebugLogger writes nothing

[reactiveui]

Splat's DebugLogger writes nothing

[grokys]

I'm seeing this problem as well.

[anaisbetts]

Yeah, I know :( An overhaul of Splat logging is definitely on the table for 2.0, because what we've got in 1.0 sucks out loud

[grokys]

Glad you said that, because I was just about to go write my own, and that's a rabbit hole I really don't want to have to go down... I'll wait in anticipation.

[moswald]

@grokys, it's trivial to add your own debug logger. I think I copied mine directly from the Splat source:

    public class LogImpl : ILogger
    {
        public void Write(string message, LogLevel logLevel)
        {
            if ((int)logLevel < (int)Level)
            {
                return;
            }

            Debug.WriteLine(message);
        }

        public LogLevel Level { get; set; }
    }

And then you just add it as an instance of the ILogger in your Locator:

Locator.CurrentMutable.RegisterConstant(new LogImpl { }, typeof(ILogger));

[grokys]

@moswald - yeah, I've already done that, but there are various other problems with the logging framework I'm having to work around too such as #41.

[anaisbetts]

@grokys What would you add? I have ideas but I definitely want to hear others.

One thing that motivates me to write my own instead of using the legion of others, is that most loggers give zero thought to perf concerns on mobile devices - they're all written for servers, so none of them think about CPU perf or allocations. The best imho is Serilog, but it allocates way too much stuff imho to be usable on mobile

[grokys]

Well, the things I would add if I were to roll my own may be a little specific to my particular problem (https://github.com/grokys/Perspex/).

• I'd be able to filter by individual object/type. So when I'm debugging a TreeView I'd be able to log only messages from TreeViews, or only a particular instance. This would be configured at runtime.
• I'd have categories that spanned multiple classes, (e.g. "Styling", "Layout" etc rather than by individual class) and be able to filter by this.

The main reason I'm using Splat's logger is simply that I'm used to using RxUI and I need a logger and service locator, so splat made sense.

[ghuntley]

See also #123 and #58

[Belorus]

@paulcbetts Please have a look at XLog - https://github.com/Belorus/XLog/wiki if you care about logging performance.
Basically the most important thing to care of was memory traffic. Reducing heap allocations to 1 allocation per log entry allowed to beat everything we have in nuget

[ghuntley]

@Belorus would you be interested in rewriting our implementation instead of having to maintain xlog?

[Belorus]

@ghuntley, sure, i can try. Would be pleasure if it will save few milliseconds for more people. I'll get in touch with PR in a week with results

[ghuntley]

@Belorus just make sure you open a discussion / WIP with your changes early before storming ahead.

[cabauman]

Copying that snippet from @moswald's comment worked for me (adding our own logger implementation). Wasn't getting anything in the output window, otherwise. Thanks.

[ghuntley]

This knowledge has been documented over at https://reactiveui.net/docs/guidelines/debugging/enable-framework-logging 🚢

[cabauman]

Thanks @ghuntley but I've already tried that section of the documentation before. That page, among a few others, are blank.

EDIT: Okay, that page isn't blank anymore. Thanks again ghuntley.