Comments (3)
Hrm, good catch. I'd personally like to keep the transformers Public, as that allows folks to use all of our Stream and StreamTransformers classes individually without needing to pull in all of Observable if they really only need one or two items.
In this case, great call. We should inspect our operators and make sure they can be reused. Secondly, we defo need more docs on these classes. We've just made them public without much explanation thus far, something we'll certainly fix :)
from rxdart.
hmmm, we could fix this by storing values in a Map for example,
take the min/max transformer, instead of storing a single value
in the transformer class, we could create a Map<EventSink, T>
instead, which stores values in relation to the provided Stream sink.
On close, we could delete the related EventSink
key from that Map
.
from rxdart.
Another option: Now that we've got a class with an internal factory method, every time bind
is called, we could build a new transformer internally and bind that, rather than building the transformer immediately upon creation and re-binding that over and over.
Although I think we should generally review our transformers and see if we can avoid doing that, for some cases it might make sense to ensure we don't have state problems.
from rxdart.
Related Issues (20)
- BehaviorSubject doesn't provide value via 'first' in test environment HOT 1
- Addition of Copyright Notice HOT 3
- StackOverflowError forwarding_stream.dart in _MultiControllerSink.add HOT 3
- StreamSubscription pause()/resume() with PublishSubject.stream.listen not working HOT 2
- throttled stream ignores the close command
- BehaviorSubject() doesn't provide value with defaultIfEmpty(...) HOT 1
- When will the version bump to 1.y.z HOT 1
- BUG: non-broadcast Stream cannot be listened more than once when asyncMap is used HOT 5
- .shareValue() does not provide up-to-date .value HOT 2
- Use records in combine latest etc.
- rx.zip and rx.combineLast are not work anymore
- Nested asynchronous loops don't work with groupBy HOT 1
- How can we combine multiple streams if they depends on each other? HOT 6
- ValueStream.map should return ValueStream (?)
- Combining 2 stream with ZipStream.zip2 doesn't update streambuilder UI HOT 2
- Rx.using: clean up order
- LICENSE is not detected by pub.dev HOT 1
- `PublishSubject` doesn't work with `concatWith` operator HOT 2
- Fix `Rx.using` docs
- Use record in pairwise() HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxdart.