Error if path has spaces

[reactivex]

Error if path has spaces

[mgechev]

Fixed and published as part of 0.1.4.

[JamesJansson]

I just looked, there's a week old PR from dgsmith2 with almost exactly the same issue. The failure to accept this PR will be stopping a lot of people from upgrading to Angular 6. It's a hot topic off the back off IO18, so this should be seen to sooner rather than later.

[JamesJansson]

This issue needs to be reopened, because it really is a bug that needs to be resolved for Windows users. The file path is not just unescaped for tsconfig, but also the tslint and the rxjs-5-to-6migrate.json, and uses absolute paths.

If, for example, your user name in Windows is "First Last", your path will look like "C:\User\First Last..." for all of the above files, breaking the install.

[somnathswami]

yes this issue is big barrier to migrate angular 5 to angular 6 :(

[dgsmith2]

Also escaping the path to tsconfig. Usages such as the following should be working:

package.json

scripts: {
   "rxjs-migrate": "rxjs-5-to-6-migrate -p /my/path/with\\ spaces/tsconfig.app.json",
}

CLI:

$ ./node_modules/.bin/rxjs-5-to-6-migrate -p /my/path/with\ spaces/tsconfig.app.json

[mgechev]

@dgsmith2 this doesn't seem to solve:

rxjs-5-to-6-migrate -p path\ to\ your/tsconfig.json

[JamesJansson]

I've made a pull request that should fix this issue.