Comments (8)
deferredObservable
You can already use defer { .. }
with import rx.Observable.defer
so 👍 to removing this.
emptyObservable
You can use empty()
with import rx.Observable.empty
so 👍 to removing this.
observable
This just seem superfluous. Almost no one should be using create
anyway. just
, defer
, fromCallable
and fromAsync
are all better choices that will prevent you from shooting yourself in the foot. 👍 to removing this.
from rxkotlin.
They might help with readability
This is why they are here. Almost everything here is just to make code look better.
from rxkotlin.
I agree with @JakeWharton here. Pretty much any function that is not an extension function should be removed. These resemble more syntactic saccharine than syntactic sugar. They offer minimal readability benefit and makes moving from RxJava to RxKotlin more convoluted, and many will keep using the RxJava factories anyway.
Besides, if people want them that badly they can implement these functions themselves on their domain with little effort, to the point it is not even worth creating a library for. That's the great thing about Kotlin. You can create your own DSL for your needs.
@stepango would you like me to put in a PR removing all these functions?
from rxkotlin.
Agreed with @JakeWharton, @maxandron and @thomasnield. This functions will be removed in upcoming 1.x and 2.x along with some others. Feel free to reopen this issue for further discussion.
from rxkotlin.
I believe these functions are here to to comply with standard Kotlin functions like emptyArray
, emptyMap
etc.
So they do add something kotlin specific, at least emptyObservable
.
from rxkotlin.
I see, thanks.
I thought this library was adding kotlin specific readability helpers. These three methods could just as well be in the original RxJava api.
from rxkotlin.
@thomasnield I'll prefer to deprecate it first and remove it in one of the future releases
from rxkotlin.
Sounds good.
from rxkotlin.
Related Issues (20)
- RxKotlin is not resolved properly after updating Gradle to 3.4.0 HOT 17
- Admin Help - Adding a Collaborator HOT 5
- withLatestFrom() build error with RxKotlin 2.4.0 HOT 1
- Do we need to call onComplete() of subject in onDestroy() method of activity ? HOT 2
- Add mapNotNull extension HOT 1
- RxJava 3 support HOT 6
- Question about contributing: code styles
- RxKotlin 3 package name HOT 7
- Compilation error HOT 2
- Type mismatch for return type
- observeOn(AndroidSchedulers.mainThread()) HOT 2
- zipWith and Kotlin 1.4.0 HOT 4
- Add support for doOnLifecycle.
- Singles.zip does not invoke onError when one of the stream throws error
- issue with the indirect dependency component reactive-stream License
- `delay` extension reduces type detection (for `Observable.create` series)
- Update Kotlin version to use Duration?
- Kotlin multiplaform support HOT 1
- Issues with generics in Kotlin 1.8.0
- extensions for coroutine flow HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rxkotlin.