Comments (6)
Ok, so the problem is going to be how we register the transform. The big change in 0.8 was to switch to babel, which meant that we changed how we detected what needed to be transformed.
Specifically we now build up a regex and pass that into babel. AFAIK this was only tested on *nix so presumably we need to either build a better regex or there's bug in babel (I'm assuming it's our problem though).
I don't have a Windows machine super handy but this will hopefully be a pretty small fix. Would you or @gocreating be willing to help out and do a little bit of detective work to make the regex match what's being required? (might need to do options.settings.replace('\', '\\')
, some logging of the regex being built and the filename should be enlightening)
from express-react-views.
@zpao excuse me, I am not familiar with regex and react, and I think I cannot help you in the meantime.
This is a great project, and I take it as part of my seed project :)
from express-react-views.
I use node-jsx and the error did not happen.
I run npm install node-jsx
and added require('node-jsx').install();
above the router.
from express-react-views.
I got the same problem , To fix it ,I readed the Babel's docs and finded that the 'only' requires an array of glob paths, so I modified the index.js
var onlyArry = [];
onlyArry.push(options.settings.views);
moduleDetectRegEx = new RegExp('^' + options.settings.views);
require('babel/register')({
only: onlyArry
});
registered = true;
It fixed.
from express-react-views.
@xuteng - Hmm, http://babeljs.io/docs/usage/require/ indicates it takes a regex. And actually looking at the src (https://github.com/babel/babel/blob/master/src/babel/api/register/node.js#L154) it looks like both will work and it'll convert to an array and regex from that. So I think all that you're really doing is creating a regex without the leading ^
.
Can you log what options.settings.views
and filename
are? My concern with leaving off part of the regex is that we'll inadvertently catch files outside the view path.
from express-react-views.
The options.settings.views
and filename
are:
Thank you for pointing out the mistake.
However the regex I got is (?:(?=.)d:\/(?=.)work\/(?=.)newWork\/(?=.)views)
at last when passed an array at https://github.com/babel/babel/blob/master/src/babel/util.js#L99
from express-react-views.
Related Issues (20)
- onClick event listener not working
- babel-register not updated in release from nine months ago HOT 2
- document is not defined HOT 1
- Feature request: Locals as a context HOT 3
- Error: Cannot find module 'babel-core' HOT 3
- Error: Requires Babel "^7.0.0-0", but was loaded with "6.26.3" HOT 3
- If we need a view engine of ‘tsx’.
- Dynamic example is vulnerable to XSS HOT 2
- React component use HOT 1
- Dealing with different file extensions for production HOT 1
- Any plans for webpack support?
- SyntaxError: Unexpected token '<'
- Error: Cannot find module '@babel/plugin-transform-flow-strip-types'
- cannot import bootstrap when using the jsx view engine HOT 4
- Is this reactive? HOT 3
- React Dev Tools Does Not Comprehend React Components HOT 1
- React setState did not rerender the page HOT 4
- add external script file
- How to load javascript with express-react-views HOT 2
- React 17
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from express-react-views.