Giter Site home page Giter Site logo

Comments (4)

KennethKinLum avatar KennethKinLum commented on April 27, 2024 1

I think the diagram is fine, adding false would clutter it and confuse it with too many details. But maybe we could clarify how false is taking up one of the positions. I think if you read deeply and compare the code from the previous example, you can deduce it though.

@gaearon is it worth adding a note that explains that false takes up one of the positions/slots, and false isn't rendered? Or did you intentionally omit that?

because without the false, it is conceptually incorrect. My past coworkers tend to have flaky understanding of React. Ask them why and they say, "do this and this will happen", and you ask them the reasoning behind it, they can't say it, or reply with "it is what it is".

If there is an easy way to present things as close as the truth, I think we should do it. Presenting approximation or inaccurate information only deepen tech debt. Person A cannot understand it so well, and then discusses with Person B, and things get more and more vague and inaccurate.

Even the line down below in Option 2: "You might have seen keys when rendering lists. Keys aren’t just for lists!

Explaining thing with exclamation point was never the method in the past or in formal text. It is more proper as "React has a special rule that, the position of the component in the tree, together with the key, determines whether it is a component that should have its states reset". It was explained as such further down, but explaining things with exclamation point does not seem like a good start.

from reactjs.org.

rickhanlonii avatar rickhanlonii commented on April 27, 2024

I think the diagram is fine, adding false would clutter it and confuse it with too many details. But maybe we could clarify how false is taking up one of the positions. I think if you read deeply and compare the code from the previous example, you can deduce it though.

@gaearon is it worth adding a note that explains that false takes up one of the positions/slots, and false isn't rendered? Or did you intentionally omit that?

from reactjs.org.

rickhanlonii avatar rickhanlonii commented on April 27, 2024

Related: #6288

from reactjs.org.

Scramjet911 avatar Scramjet911 commented on April 27, 2024

I think the diagram is fine, adding false would clutter it and confuse it with too many details. But maybe we could clarify how false is taking up one of the positions. I think if you read deeply and compare the code from the previous example, you can deduce it though.

@gaearon is it worth adding a note that explains that false takes up one of the positions/slots, and false isn't rendered? Or did you intentionally omit that?

imo having a note that says false takes up one of the positions would help since new devs would not expect a falsy value to take up one of the positions on the tree.

from reactjs.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.