Giter Site home page Giter Site logo

Functional Attribute/Prop Node about rfcs HOT 2 CLOSED

nstepien avatar nstepien commented on June 6, 2024 2
Functional Attribute/Prop Node

from rfcs.

Comments (2)

nstepien avatar nstepien commented on June 6, 2024

I think such functional attributes should always be passed "rendered", they should be never be passed as is like components. So a component can never receive an attribute node, only its rendered value.
Unlike with components, I don't think there is really any value in passing attribute nodes.

For example

function MyComponent() {
  return (
    <ChildComponent
      // passed as is, `ChildComponent` can do `React.cloneElement(props.saveButton, ...)`
      saveButton={<Button {...props} />}
      // the `Disabled` functional attribute is rendered after `MyComponent` is rendered, and before `ChildComponent` is rendered
      disabled={<Disabled />}
    />
  );
}

This would make introducing this feature a non-breaking change.
There wouldn't be any TS/Flow user typings changes to make either, an attribute that expects a boolean can also accept a functional attribute returning a boolean.

from rfcs.

gaearon avatar gaearon commented on June 6, 2024

Hi, thanks for your suggestion. RFCs should be submitted as pull requests, not issues. I will close this issue but feel free to resubmit in the PR format.

from rfcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.