Giter Site home page Giter Site logo

Comments (2)

simonbasle avatar simonbasle commented on May 9, 2024

72f4cbd doesn't completely fix this (as subsequent invocations of onReadIdle API depends on addHandler, which went from failing on duplicate names to discarding the secondly added handler)... It makes the workaround shorter, though, with the addition of removeHandler:

public void onReadInactivity(Runnable runnable, long inactivityDuration) {

	// TODO: workaround for https://github.com/reactor/reactor-netty/issues/22
	this.inbound.removeHandler(NettyPipeline.OnChannelReadIdle);

	this.inbound.onReadIdle(inactivityDuration, runnable);
}

from reactor-netty.

rstoyanchev avatar rstoyanchev commented on May 9, 2024

I'm fine with suggested workaround but silently ignoring the second invocation doesn't seem fine. I would rather see an IllegalStateException pointing to the need to explicitly remove the existing handler first.

from reactor-netty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.