Reuse existing Buffer class if possible

[reactor]

Reuse existing Buffer class if possible

[garyrussell]

See also #52 - in order to avoid churning Direct Buffers (when supported) we will need a wrapper for them with some kind of release() method to return a direct buffer to the pool when no longer in use. Perhaps the existing Buffer class can be enhanced to support a release() method that will detect that the buffer being released is direct, and return it to the pool.

Perhaps even non-direct ByteBuffers would benefit from being pooled, to avoid gc.

[jbrisbin]

I'm working on changing some things in core to use Suppliers instead of direct references. Particularly Dispatchers, but I also was thinking that, when I get to the TCP stuff, I'll want to do a BufferSupplier as well. I also wrote the LoadingCache [1] for this purpose, so maybe we can leverage that and create a ByteBufferCache that does the rewind() when deallocating a buffer. It uses the logic that was in the BlockingQueueDispatcher, so yields the calling thread until an object becomes available (up until a timeout, then it returns a new one). It seem to work pretty well for Tasks, so no reason to think it wouldn't work for buffers as well.

[1] - https://github.com/reactor/reactor/blob/master/reactor-core/src/main/java/reactor/fn/LoadingCache.java

[smaldini]

👍

[wilkinsona]

The recent changes in Reactor TCP that Jon's working on have superseded this requirement