In-built request timeout functionality

[Renegade334]

In-built request timeout functionality

[cboden]

This feature has been started in the underlying library reactphp-legacy/socket-client#10. Once it's implemented there it should be simple enough to add here.

[clue]

👍 on supporting a timeout setting.

Though I'm not sure what the API could look like…
Also, when should we actually time out (connection timeout, whole request timeout, idle timeout etc…)?

I think it makes sense to add an API similar to reactphp-legacy/socket-client#10. Any thoughts on this @Renegade334?

[Renegade334]

Clients like cURL support both a connection timeout and a total timeout. Both would be useful, IMO, although I was originally thinking of total timeout when submitting this. The latter would be a client-level feature, I guess, whereas the former would be socket-level.

renegade@mercury:~$ curl --connect-timeout 1 http://10.255.255.1/
curl: (28) Connection timed out after 1001 milliseconds
renegade@mercury:~$ netcat -l 3456 &> /dev/null & curl --max-time 1 http://localhost:3456/
curl: (28) Operation timed out after 1000 milliseconds with 0 bytes received

[WyriHaximus]

@Renegade334 yes that makes sense. We could even go for 3 time outs:

• Connect timeout, how long we wait for the connection to be created, done in socket-client
• Response timeout, how long a server can take before responding
• Response body timeout, how long it can take before the entire response body is downloaded

[clue]

FWIW: This is likely related to #36. Possible implementation approach could be to just close() the request once the timeout timer fires.

[clue]

I'm closing this as it is already supported by the new HTTP client that has been merged into react/http via reactphp/http#368 You should upgrade as per #152 👍