Can't validate inputs

[reagent-project]

Can't validate inputs

[holmsand]

Yes, that it definitely a bug (and yes, that is kind of a dark corner both of Reagent and React...).

My (admittedly rather ugly) code tries to work around that React's controlled components don't like asynchronous rendering. Inputs with an onChange handler only allow changes when that handler runs (that code in React seems to have moved here: https://github.com/facebook/react/blob/master/src/browser/dom/components/ReactDOMInput.js - see in particular the shouldComponentUpdate method).

I'll have a think about what's going wrong as well.

And if you want look for a fix: the easiest way to run the tests, and play with the code in general, is to run "make runtest" in the top-level directory. That builds the entire demo-site, and runs tests both in browser and node. Probably doesn't work on windows, where something like lein with-profile test,dev cljsbuild auto client may be required.

[holmsand]

I think I've found an acceptable solution, in e539069

For "controlled components", Reagent now sets the value of inputs directly, rather than going through React, and schedules a forceUpdate whenever on-change is run, so that the value of the input is reset to its original value unless on-change leads to an update of the :value property.

That way, the value of the input field and the underlying atom should always be kept in sync.

[mainej]

Thanks @holmsand! The fix is a little more complicated than I expected, but it makes sense. Looking forward to testing it in your next release.

[holmsand]

Yes, it was a little more complicated than I expected too at first :)

Btw (and sorry if this is blindingly obvious to you), if you want to test it right now, you can just do lein install in the Reagent directory, and then change your dependency on Reagent in your project.clj to [reagent "0.4.2-SNAPSHOT"].

[mainej]

Works great! Thanks for the tips - still new to clojure and lein.