Edited message thread originators not properly rendered

[podviaznikov]

Edited message thread originators not properly rendered

[podviaznikov]

yes, deleted

[podviaznikov]

verified. thank you!

[ReagentX]

The only place we add table elements is for edited messages:

imessage-exporter/imessage-exporter/src/exporters/html.rs

Lines 715 to 741 in 569762c

	out_s.push_str("<table>");
	for i in 0..edited_message.items() {
	let last = i == edited_message.items() - 1;
	if let Some((timestamp, text, _)) = edited_message.item_at(i) {
	match previous_timestamp {
	None => out_s.push_str(&self.edited_to_html("", text, last)),
	Some(prev_timestamp) => {
	let end = get_local_time(timestamp, &self.config.offset);
	let start = get_local_time(prev_timestamp, &self.config.offset);
	let diff = readable_diff(start, end).unwrap_or_default();
	out_s.push_str(&self.edited_to_html(
	&format!("Edited {diff} later"),
	text,
	last,
	));
	}
	}
	// Update the previous timestamp for the next loop
	previous_timestamp = Some(timestamp);
	}
	}
	out_s.push_str("</table>");

Did the messages you are viewing contain HTML themselves? If so this will be fixed in #219.

[ReagentX]

The generated HTML of an edited message looks like this:

<div class="message">
    <div class="sent iMessage">
        <p><span class="timestamp">Nov 18, 2022 6:17:54 PM</span>
            <span class="sender">Me</span>
        </p>
        <hr>
        <div class="message_part">
            <div class="edited">
                <table>
                    <tbody>
                        <tr>
                            <td><span class="timestamp"></span></td>
                            <td>First message </td>
                        </tr>
                    </tbody>
                    <tbody>
                        <tr>
                            <td><span class="timestamp">Edited 6 seconds later</span></td>
                            <td>Edit 1</td>
                        </tr>
                    </tbody>
                    <tbody>
                        <tr>
                            <td><span class="timestamp">Edited 5 seconds later</span></td>
                            <td>Edit 2</td>
                        </tr>
                    </tbody>
                    <tfoot>
                        <tr>
                            <td><span class="timestamp">Edited 9 seconds later</span></td>
                            <td>Edited message</td>
                        </tr>
                    </tfoot>
                </table>
            </div>
        </div>
        <div class="reactions">
            <hr>
            <p>Reactions:</p>
            <div class="reaction"><span class="reaction"><b>Liked</b> by Me</span></div>

        </div>
    </div>
</div>

I dont see an unclosed div here.

[podviaznikov]

Hard to reproduce because basically now generated html is broken.

But here on the screenshot I have 3 separated messages and last two are nested inside 3rd to last in HTML because 3rd to last is missing one closing div.

[ReagentX]

What do the bubbles look like in the messages app? It looks like there was a thread off of a message that was deleted.

[podviaznikov]

yes, it was deleted. only message "Hi2" 2nd to last is visible.

[ReagentX]

Just to be clear—these were messages that were deleted from the conversation, not messages that were unsent from the conversation, correct?

[ReagentX]

Rendering the thread is definitely broken for edited messages. This is the culprit:

imessage-exporter/imessage-exporter/src/exporters/html.rs

Line 301 in b9b4ed6

continue;

To replicate the bug:

1. Send a message
2. Edit that message
3. Send a second message
4. Reply to 1. with a third message
5. Edit the third message

[ReagentX]