Removing the text with social media icons

[real-dev-squad]

Removing the text with social media icons

[brandong512]

Ok hopefully this one checks all the boxes 🙂

[brandong512]

I see, thank you for the clarification. I'll go ahead and make those changes.

[KhushalAbrol]

I want to work on this issue. Please assign me this

[KhushalAbrol]

#117 Please review this pull request

[brandong512]

I can take this on. Can you please assign this to me?

[brandong512]

So I've removed the text and also added a tiny animation on hover for each icon. How does this look?

?

[rohan09-raj]

So I've removed the text and also added a tiny animation on hover for each icon. How does this look? ?

This looks awesome🔥
1- What is the width and height of icons you are using (when hover is not there) ??
2- Adding more to this, the hover transition should not affect the other UI elements.

[brandong512]

1- width & height are starting 20px and growing up to 30px in .5 second
2- sure I'll work on that too

[rohan09-raj]

@brandong512
Can you please make it 35px and on hovering it should be 40 or 45px. Whatever looks good to you.
Also, if the icon quality on making it 35px goes down, you can use similar new icons from Google but keep in mind that it should be similar.

[brandong512]

Ok sounds good. I'll find some SVG icons and share them with you. That way when they scale they won't lose any quality

[brandong512]

Here are the svg icons I've found, can you confirm that these are similar enough?

[rohan09-raj]

@brandong512 Yes, they look good and are very similar to the icons we have. Go ahead with them.

[brandong512]

Here is the animation with stable sections so they don't affect the elements around. Also, the logos were changed to SVGs starting at 35px and growing up to 45px. Let me know what you think

[rohan09-raj]

@brandong512 I have added a link in the description. Please refer to that link. The hover should be specific on the image element and nothing else should be affected. Also, keep in mind that it should be mobile responsive, so check for different screen sizes that icon size is fine or not.
Thanks for updating the icons.

[rohan09-raj]

Great 💯, raise a PR, attach this short video to description for both mobile view and desktop view, and write Closes #<issue_number>. Now comes the code review part😁.