[BUG] Display error when target page title is charset gb2312 (a different charset vs utf-8)

[realodix]

[BUG] Display error when target page title is charset gb2312 (a different charset vs utf-8)

[realodix]

urlhub/app/Services/UHubLinkService.php

Line 65 in 772aa00

$title = app(Embed::class)->get($webAddress)->title ?? $defaultTitle;

It looks like the embed failed to deal with the encoding issue.

You can create an issue at https://github.com/oscarotero/Embed/issues

[xiaohuilam]

urlhub/app/Services/UHubLinkService.php

Line 65 in 772aa00

$title = app(Embed::class)->get($webAddress)->title ?? $defaultTitle;

It looks like the embed failed to deal with the encoding issue.

You can create an issue at https://github.com/oscarotero/Embed/issues

Thanks for pointing out the dependencies.

by my understanding, oscarotero/Embed provided some methods to crawl page url and pick up title or meta property from them. But it doesn't know which charset the returned value should be encoded, because it depends the realodix/urlhub's database configuration, and its HTML base layout defination.

I think this should be fixed by calling a native method mb_convert_encoding after oscarotero/Embed returned the title.

I do appreciate for you open sourced this powerful application.

• demo gb2312 URL: https://www.qq.com.

[realodix]

If you want to work on PR to fix it, it's very appreciated

[xiaohuilam]

If you want to work on PR to fix it, it's very appreciated

OK, I'll see how to checkout a new branch in my repo to get involved of this.