Giter Site home page Giter Site logo

Comments (4)

jxnblk avatar jxnblk commented on May 7, 2024 3

Yeah I'm totally open to building out the Media component a little better.

My usual instinct is to say that every image should have width and height attributes, but this component doesn't really support that at the moment.

from rebass.

phated avatar phated commented on May 7, 2024

@contra are you able to use the theme context to pass a maxHeight/naxWidth css style?

from rebass.

yocontra avatar yocontra commented on May 7, 2024

@phated No - seems like there's no way to style the image at all. (https://github.com/jxnblk/rebass/blob/master/src/Media.js#L36 passes no styles through)

Maybe a better solution would be to break the image out of the Media innards and have the user specify it (like you do with text and heading)

from rebass.

phated avatar phated commented on May 7, 2024

Yeah, a change just landed that split the Step component out of SequenceMap. I think the same could/should happen here.

from rebass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.