Negative interval number

[Kaiyrgali]

Negative interval number

[ckifer]

That helps, thanks!

The problem is that this was undocumented behavior that the current maintainers didn't know existed and it wasn't in any test cases. Not allowing a negative number makes sense logically, so that's what was done.

We should give a way back to you to accomplish the same end result if possible

@nikolasrieble any thoughts on this?

[ckifer]

@Kaiyrgali previous to what, can you give more details? What version did this happen in, what version are you using?

Can you create a codesandbox example of what you had that worked, vs what does not work now?

[Kaiyrgali]

@ckifer The problem probably starts with a pull request #3392

For example, in recharts version "2.0.6" the Y axis is thinned out with negative interval values
https://codesandbox.io/p/sandbox/recharts-negative-interval-v-2-0-6-k23tw4

The latest version already has a problem
https://codesandbox.io/p/sandbox/recharts-problem-negative-interval-v-2-12-4-mq5tl9

[nikolasrieble]

Thank you for reporting this. I likely introduced the bug some time earlier.
Admittedly, I am surprised that this ever worked, because it contradicts my understanding of the functionality. The interval is supposed to be the amount of ticks left out.

interval = 1 --> Every second tick is shown. 
interval = 0 --> Every tick is shown. 

In this mental model, I do not understand what a negative interval means.
How would you expect it to work?

What would the difference be between

interval = -1 --> ? 
interval = -2 --> ? 

[Kaiyrgali]

interval = -1 all ticks were hidden
interval = -2 and further, some ticks were hidden according to some strange logic