Set image name 'output' on success

[redhat-actions]

Set image name 'output' on success

[tetchel]

i guess somewhat related is, the image name is currently expected to include the tag, which seems counter-intuitive to me. for push-to-registry, name and tag are separate. should we split that into two inputs?

[divyansh42]

I think splitting the input into name and tag would make a lot more sense.

[divyansh42]

What if we output the image digest? I see tekton task use to output 'digest' in the results of the task.
Ref: https://github.com/tektoncd/catalog/blob/master/task/buildah/0.2/buildah.yaml#L54

[tetchel]

isn't the digest a hash? I was thinking more the image name:tag that could then be passed to the push-to-registry step.

Digest could be useful separately

[lstocchi]

Also the docker build-push-action returns a digest https://github.com/docker/build-push-action/blob/master/action.yml
I'm really not sure if they returns the digest or the image id (the same in the buildah task @divyansh42 posted, the name is confusing) but my vote goes to the image id.

It really makes no sense for me to use the output to return something that is not made up by the action. If we return image:tag we are just returning an input. A user could easily create a variable and use that without hard-coding the actual value multiple times.

[tetchel]

in my own example, the name and tag were stored separately because they are passed to the action as separate inputs, but after the action they are one output, that's all.

We can have as many outputs as we want, so name, url, and ID are all on the table, we don't have to pick just one.

[tetchel]

the full image URL is currently printed but would also be a useful output (more useful than the name) because i'll pass it to the subsequent deploy step

edit: redhat-actions/push-to-registry#4

[tetchel]

I added this in a65863e