Giter Site home page Giter Site logo

Comments (5)

goodwinos avatar goodwinos commented on July 20, 2024

There was some discussion a while back with Marko (pmrep author) and other PCP developers around this proposal and the consensus is that it would be too difficult/intrusive to retrofit this feature into pmrep (which is the back-end for pcp2zabbix). pmrep was never designed to re-parse it's metric arguments and config after starting. The work-around is to restart pcp2zabbix, at which time pmrep will re-evaluate the PMNS. The Zabbix receiver would need to tolerate reconnection of the datasource - not sure if that is already the case, but likely.

from osd-monitor-poc.

fche avatar fche commented on July 20, 2024

The need continues to exist. At the very least pmrep could be configurable so that it can exit when it receives a PMCD_NAMES_CHANGE. That would give the caller an opportunity to restart it.

from osd-monitor-poc.

fche avatar fche commented on July 20, 2024

If the above were combined with tolerance by pmrep to unresolvable metric names (so it doesn't quit, just ignores them), we can have what we need without major pmrep surgery.

from osd-monitor-poc.

goodwinos avatar goodwinos commented on July 20, 2024

Thanks to Nathan and Marko, pmrep and all pmrep/pmconfig based pcp2xxx tools in upstream pcp-4.3.0 (including pcp2zabbix) now have support for (a) --ignore-unknown to tolerate unresolved metric names and (b) --names-change where supported options are 'ignore' (default), or 'abort'.

See upstream commits : 2aa0081f24cf1db0172a 86e6b73f5aca768a 71d684326aeb22b43 7673438cd7cd8e c1caf330fbd86236 04fd0569bea5c6dc22b and related QA.

These commits should be sufficient for this issue so pcp2zabbix can abort on PMCD_NAMES_CHANGE (and be restarted e.g. by pmmgr), and tolerate unresolvable metric names on startup instead of exiting.

from osd-monitor-poc.

goodwinos avatar goodwinos commented on July 20, 2024

As per the above, this feature is now in upstream master and will release with pcp-4.3.0 (December 21).

from osd-monitor-poc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.